chore: fix tests

Author: lukasholzer

src/utils/detect-server-settings.js

@@ -215,7 +215,6 @@ const detectFrameworkSettings = async ({ projectDir }) => {
   }
 }
 
-/** @deprecated  remove it  */
 const hasCommandAndTargetPort = ({ devConfig }) => devConfig.command && devConfig.targetPort
 
 /**
@@ -279,11 +278,10 @@ const detectServerSettings = async (devConfig, flags, projectDir) => {
   } else if (devConfig.framework === '#auto') {
     // this is the default CLI behavior
 
-    // detect the framework settings
-    const frameworkSettings = await detectFrameworkSettings({ projectDir })
+    const runDetection = !hasCommandAndTargetPort({ devConfig })
+    const frameworkSettings = runDetection ? await detectFrameworkSettings({ projectDir }) : undefined
 
-    console.log(devConfig.targetPort)
-    if (frameworkSettings === undefined) {
+    if (frameworkSettings === undefined && runDetection) {
       log(`${NETLIFYDEVWARN} No app server detected. Using simple static server`)
       settings = await handleStaticServer({ flags, devConfig, projectDir })
     } else {

src/utils/types.d.ts

@@ -1,4 +1,4 @@
-export type FrameworkNames = '#static' | '#auto' | '#custom'
+export type FrameworkNames = '#static' | '#auto' | '#custom' | string
 
 export type FrameworkInfo = {
   build: {

tests/framework-detection.test.js

@@ -65,7 +65,7 @@ test('should use static server when framework is set to #static', async (t) => {
   })
 })
 
-test('should warn if using static server and `command` is configured', async (t) => {
+test('should log the command if using static server and `command` is configured', async (t) => {
   await withSiteBuilder('site-with-index-file', async (builder) => {
     await builder
       .withContentFile({

tests/snapshots/framework-detection.test.js.md

@@ -64,13 +64,12 @@ Generated by [AVA](https://avajs.dev).
     ␊
     `
 
-## should warn if using static server and `command` is configured
+## should log the command if using static server and `command` is configured
 
 > Snapshot 1
 
     `◈ Netlify Dev ◈␊
     ◈ Using simple static server because '--dir' flag was specified␊
-    ◈ Ignoring command setting since using a simple static server. Configure 'command' and 'targetPort' for a custom setup␊
     ◈ Running static server from "site-with-index-file/public"␊
     ␊
     ◈ Static server listening to 88888␊
@@ -118,7 +117,7 @@ Generated by [AVA](https://avajs.dev).
 
     `◈ Netlify Dev ◈␊
     ◈ Starting Netlify Dev with Create React App␊
-    ◈ Failed launching framework server. Please verify 'react-scripts' exists`
+    ◈ Failed running command: react-scripts start. Please verify 'react-scripts' exists`
 
 ## should throw when forcing a non supported framework
 
@@ -171,7 +170,7 @@ Generated by [AVA](https://avajs.dev).
     ◈ Setup a netlify.toml file with a [dev] section to specify your dev server settings.␊
     ◈ See docs at: https://cli.netlify.com/netlify-dev#project-detection␊
     ◈ Starting Netlify Dev with #custom␊
-    ◈ Failed launching framework server. Please verify 'oops-i-did-it-again' exists`
+    ◈ Failed running command: oops-i-did-it-again forgot-to-use-a-valid-command. Please verify 'oops-i-did-it-again' exists`
 
 ## should prompt when multiple frameworks are detected