Skip to content

Conversation

mrstork
Copy link
Contributor

@mrstork mrstork commented Apr 29, 2025

Summary

See https://answers.netlify.com/t/build-plugins-end-of-support-for-node-js-14-node-js-16/136405
Part of FRB-1780

Prior to merging:

  • Update the list of required tests in build repository settings to match new test names
  • Merge any outstanding release branches
  • Wait until May 14

A picture of a cute animal (not mandatory, but encouraged)

image

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork force-pushed the update-node-engine-field branch 3 times, most recently from 9d052ce to 33dfed8 Compare April 29, 2025 22:08
@netlify netlify deleted a comment from github-actions bot Apr 29, 2025
@netlify netlify deleted a comment from github-actions bot Apr 29, 2025
@netlify netlify deleted a comment from github-actions bot Apr 29, 2025
@netlify netlify deleted a comment from github-actions bot Apr 29, 2025
@netlify netlify deleted a comment from github-actions bot Apr 29, 2025
@netlify netlify deleted a comment from github-actions bot Apr 30, 2025
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

1 similar comment
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork force-pushed the update-node-engine-field branch from 305b6a5 to 8a3ce46 Compare April 30, 2025 13:21
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork force-pushed the update-node-engine-field branch from 8a3ce46 to c0483d1 Compare April 30, 2025 13:22
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork force-pushed the update-node-engine-field branch from c0483d1 to f672279 Compare April 30, 2025 14:25
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork marked this pull request as ready for review May 12, 2025 16:42
@mrstork mrstork requested a review from a team as a code owner May 12, 2025 16:42
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

1 similar comment
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@mrstork mrstork force-pushed the update-node-engine-field branch from 9eeecd5 to 81481a1 Compare May 12, 2025 17:58
pieh
pieh previously approved these changes May 12, 2025
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only question is the 18.20 minimum. Is it necessary? Should we announce it first? It's also going to bump the CLI min. from 18.14.0 to 18.20.0.

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

JakeChampion
JakeChampion previously approved these changes May 14, 2025
@mrstork mrstork dismissed stale reviews from JakeChampion and pieh via 1b9acc1 May 14, 2025 15:29
@mrstork mrstork force-pushed the update-node-engine-field branch from 0aba285 to 1b9acc1 Compare May 14, 2025 15:29
Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Copy link
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@netlify netlify deleted a comment from serhalp May 14, 2025
@mrstork mrstork merged commit 9917ef4 into main May 14, 2025
34 checks passed
@mrstork mrstork deleted the update-node-engine-field branch May 14, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants