Skip to content

feat!: return boolean from delete() #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

feat!: return boolean from delete() #98

merged 1 commit into from
Nov 9, 2023

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Changes the return value of the delete() method to be a boolean indicating whether a blob was actually deleted.

@eduardoboucas eduardoboucas requested a review from a team as a code owner November 9, 2023 12:58
@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 699588b
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/654cd7681672ae0008b69055
😎 Deploy Preview https://deploy-preview-98--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 9, 2023
ascorbic
ascorbic approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@eduardoboucas eduardoboucas merged commit a566287 into main Nov 9, 2023
@eduardoboucas eduardoboucas deleted the feat/delete-return-value branch November 9, 2023 13:32
@token-generator-app token-generator-app bot mentioned this pull request Nov 9, 2023
Merged
@eduardoboucas eduardoboucas mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ascorbic ascorbic ascorbic approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardoboucas @ascorbic