Skip to content

Conversation

eduardoboucas
Copy link
Member

Which problem is this pull request solving?

Stops URL-encoding keys and adds a new set of validation rules for both blob keys and store names.

Related to https://github.com/netlify/pillar-runtime/issues/763.

Closes https://github.com/netlify/pillar-runtime/issues/760.

BREAKING CHANGE: Stores and keys are no longer URL-encoded and must follow a new set of naming rules
@eduardoboucas eduardoboucas requested a review from a team as a code owner October 23, 2023 13:11
@netlify
Copy link

netlify bot commented Oct 23, 2023

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 8274948
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/6536bc2a0a7f0500099f4c8c
😎 Deploy Preview https://deploy-preview-80--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Oct 23, 2023
@eduardoboucas eduardoboucas merged commit af867f8 into main Oct 24, 2023
@eduardoboucas eduardoboucas deleted the feat/validate-keys branch October 24, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants