feat(ui): add ClassRoom Timer #1288

Matrixbirds · 2022-01-12T09:25:07Z

Add Timer to flat-components.
Add Timer to renderer-app and flat-web.

BlackHole1

Countdown => Timer

desktop/renderer-app/src/pages/BigClassPage/index.tsx

packages/flat-components/src/components/ClassroomPage/Countdown/index.tsx

desktop/renderer-app/src/components/AppStoreButton/index.tsx

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx

packages/flat-components/src/components/ClassroomPage/Timer/style.less

desktop/renderer-app/src/pages/BigClassPage/index.tsx

desktop/renderer-app/src/pages/OneToOnePage/index.tsx

desktop/renderer-app/src/pages/SmallClassPage/index.tsx

web/flat-web/src/pages/BigClassPage/index.tsx

web/flat-web/src/pages/OneToOnePage/index.tsx

web/flat-web/src/pages/SmallClassPage/index.tsx

web/flat-web/src/components/AppStoreButton/index.tsx

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx

rename countdown to timer

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx

…dex.tsx Co-authored-by: Black-Hole <[email protected]>

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx

…dex.tsx

web/flat-web/src/pages/SmallClassPage/index.tsx

desktop/renderer-app/src/components/AppStoreButton/index.tsx

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx

BlackHole1 · 2022-01-17T11:10:10Z

please re-review

cc: @LitoMore

Matrixbirds requested review from BlackHole1 and Cheerego7 January 12, 2022 09:26

BlackHole1 requested changes Jan 12, 2022

View reviewed changes

Matrixbirds requested a review from BlackHole1 January 13, 2022 03:07

BlackHole1 requested changes Jan 13, 2022

View reviewed changes

LitoMore requested changes Jan 13, 2022

View reviewed changes

hyrious previously approved these changes Jan 13, 2022

View reviewed changes

Matrixbirds dismissed hyrious’s stale review via dc41bc2 January 13, 2022 08:29

BlackHole1 requested changes Jan 14, 2022

View reviewed changes

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx Outdated Show resolved Hide resolved

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx Outdated Show resolved Hide resolved

BlackHole1 changed the title ~~feat(ui): add ClassRoom Countdown~~ feat(ui): add ClassRoom Timer Jan 14, 2022

Matrixbirds added 8 commits January 17, 2022 11:50

feat(ui): add Countdown

e65ed53

fix(eslint): format

b38366f

fix(component): use date-fns in Countdown

8f85130

fix(component): rename Countdown to Timer

9ae42d2

fix(component): useClockTick support duration

b7c4f71

rename countdown to timer

fix(component): adjust negated conditions

6c3b4d1

fix(component): rename timer

e1726a9

fix(component): remove timer in AppStoreButton

9561c81

Matrixbirds force-pushed the feat_add_clock_tick branch from f5af1ec to 9561c81 Compare January 17, 2022 03:50

Matrixbirds added 2 commits January 17, 2022 11:52

fix(component): format code

99f91e9

fix(component): rename timer

7441390

BlackHole1 requested changes Jan 17, 2022

View reviewed changes

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx Outdated Show resolved Hide resolved

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx Outdated Show resolved Hide resolved

Matrixbirds and others added 2 commits January 17, 2022 17:05

fix(component): timer types

fb7e29c

Update packages/flat-components/src/components/ClassroomPage/Timer/in…

4401926

…dex.tsx Co-authored-by: Black-Hole <[email protected]>

BlackHole1 requested changes Jan 17, 2022

View reviewed changes

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx Outdated Show resolved Hide resolved

BlackHole1 and others added 4 commits January 17, 2022 17:12

Update packages/flat-components/src/components/ClassroomPage/Timer/in…

f6da714

…dex.tsx

fix(component): use NaN as initialize value to <Timer />

df9967f

Merge remote-tracking branch 'origin' into feat_add_clock_tick

a8fb79c

rename

ad0748d

Cheerego7 reviewed Jan 17, 2022

View reviewed changes

web/flat-web/src/pages/SmallClassPage/index.tsx Outdated Show resolved Hide resolved

BlackHole1 requested changes Jan 17, 2022

View reviewed changes

desktop/renderer-app/src/components/AppStoreButton/index.tsx Outdated Show resolved Hide resolved

Matrixbirds added 2 commits January 17, 2022 17:46

fix(component): revert countdown code

de76fd2

fix(component): revert countdown code

58bf559

Matrixbirds force-pushed the feat_add_clock_tick branch from a6a7d0d to 58bf559 Compare January 17, 2022 09:47

Cheerego7 reviewed Jan 17, 2022

View reviewed changes

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx Outdated Show resolved Hide resolved

Matrixbirds added 3 commits January 17, 2022 18:16

refactor(component): use react schedule timing update

1efd905

refactor(component): fix timing

3b5fd43

refactor(component): format code

48c619b

Cheerego7 reviewed Jan 17, 2022

View reviewed changes

packages/flat-components/src/components/ClassroomPage/Timer/index.tsx Outdated Show resolved Hide resolved

Matrixbirds added 3 commits January 17, 2022 19:04

refactor(component): format code

6bc3ea2

fix(assets): style

48ce88f

refactor(component): format code

2a7a70c

BlackHole1 approved these changes Jan 17, 2022

View reviewed changes

Cheerego7 approved these changes Jan 17, 2022

View reviewed changes

LitoMore approved these changes Jan 17, 2022

View reviewed changes

BlackHole1 merged commit dbd49e9 into netless-io:main Jan 17, 2022

feat(ui): add ClassRoom Timer #1288

feat(ui): add ClassRoom Timer #1288

Uh oh!

Conversation

Matrixbirds commented Jan 12, 2022 • edited by BlackHole1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BlackHole1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BlackHole1 commented Jan 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Matrixbirds commented Jan 12, 2022 •

edited by BlackHole1

Loading