chore(eslint): add no-negated-condition rule

Author: LitoMore

.eslint.common.js

@@ -64,6 +64,7 @@ const eslintCommon = {
             curly: "error",
             "no-multi-str": "warn",
             "no-native-reassign": "warn",
+            "no-negated-condition": "error",
             "no-negated-in-lhs": "warn",
             "no-new-func": "warn",
             "no-new-object": "warn",

desktop/renderer-app/src/api-middleware/rtm.ts

@@ -352,7 +352,18 @@ export class Rtm extends EventEmitter {
             return;
         }
 
-        if (peerId !== undefined) {
+        if (peerId === undefined) {
+            await this.commands.sendMessage(
+                {
+                    messageType: AgoraRTM.MessageType.TEXT,
+                    text: JSON.stringify({ t: type, v: value }),
+                },
+                { enableHistoricalMessaging: keepHistory },
+            );
+            if (NODE_ENV === "development") {
+                console.log("[RTM] send group command: ", type, value);
+            }
+        } else {
             await polly()
                 .waitAndRetry(retry)
                 .executeForPromise(async (): Promise<void> => {
@@ -371,17 +382,6 @@ export class Rtm extends EventEmitter {
                         return Promise.reject("peer not received");
                     }
                 });
-        } else {
-            await this.commands.sendMessage(
-                {
-                    messageType: AgoraRTM.MessageType.TEXT,
-                    text: JSON.stringify({ t: type, v: value }),
-                },
-                { enableHistoricalMessaging: keepHistory },
-            );
-            if (NODE_ENV === "development") {
-                console.log("[RTM] send group command: ", type, value);
-            }
         }
     }
 

desktop/renderer-app/src/pages/DeviceCheckPages/MicrophoneCheckPage/index.tsx

@@ -172,13 +172,7 @@ export const MicrophoneCheckPage = (): React.ReactElement => {
     }
 
     function renderFooter(): React.ReactNode {
-        if (!isSuccess) {
-            return (
-                <Button type="primary" onClick={resetCheck} className="device-check-modal-btn">
-                    {t("test-again")}
-                </Button>
-            );
-        } else {
+        if (isSuccess) {
             return (
                 <Button
                     type="primary"
@@ -188,6 +182,12 @@ export const MicrophoneCheckPage = (): React.ReactElement => {
                     {t("ok")}
                 </Button>
             );
+        } else {
+            return (
+                <Button type="primary" onClick={resetCheck} className="device-check-modal-btn">
+                    {t("test-again")}
+                </Button>
+            );
         }
     }
 

packages/flat-components/src/components/ErrorPage/index.tsx

@@ -15,10 +15,10 @@ export const ErrorPage: React.FC = () => {
     const { t } = useTranslation();
 
     const goHome = (): void => {
-        if (location.pathname !== "/") {
-            history.push("/");
-        } else {
+        if (location.pathname === "/") {
             window.location.reload();
+        } else {
+            history.push("/");
         }
     };
 

packages/flat-components/src/components/InviteModal/index.tsx

@@ -41,9 +41,9 @@ export const InviteModal: React.FC<InviteModalProps> = ({
 
         const formatBeginTime = completeTimeFormat(beginTime);
         const formatEndTime =
-            differenceInCalendarDays(beginTime, endTime) !== 0
-                ? completeTimeFormat(endTime)
-                : onlySuffixTimeFormat(endTime);
+            differenceInCalendarDays(beginTime, endTime) === 0
+                ? onlySuffixTimeFormat(endTime)
+                : completeTimeFormat(endTime);
 
         return `${formatBeginTime}~${formatEndTime}`;
     }, [beginTime, endTime]);

packages/flat-components/src/components/LoginPage/LoginContent/index.tsx

@@ -28,7 +28,16 @@ export const LoginContent: React.FC<LoginContentProps> = ({ onLogin, privacyURL,
                 classNames="slider-in"
                 unmountOnExit
             >
-                {!inPageLogin ? (
+                {inPageLogin ? (
+                    <div className="login-content-container">
+                        <div className="qr-code-container">
+                            <div className="qr-code">{inPageLogin}</div>
+                            <a className="qr-code-link" onClick={() => setInPageLogin(void 0)}>
+                                {t("login-using-other-methods")}
+                            </a>
+                        </div>
+                    </div>
+                ) : (
                     <div className="login-content-container">
                         <div className="login-content-logo">
                             <img src={logoSVG} />
@@ -40,10 +49,10 @@ export const LoginContent: React.FC<LoginContentProps> = ({ onLogin, privacyURL,
                         <div className="login-content-channel">
                             <LoginChannel
                                 onLogin={loginChannel => {
-                                    if (!isChecked) {
-                                        void message.info(t("agree-terms"));
-                                    } else {
+                                    if (isChecked) {
                                         setInPageLogin(onLogin(loginChannel));
+                                    } else {
+                                        void message.info(t("agree-terms"));
                                     }
                                 }}
                             />
@@ -64,15 +73,6 @@ export const LoginContent: React.FC<LoginContentProps> = ({ onLogin, privacyURL,
                             </Checkbox>
                         </div>
                     </div>
-                ) : (
-                    <div className="login-content-container">
-                        <div className="qr-code-container">
-                            <div className="qr-code">{inPageLogin}</div>
-                            <a className="qr-code-link" onClick={() => setInPageLogin(void 0)}>
-                                {t("login-using-other-methods")}
-                            </a>
-                        </div>
-                    </div>
                 )}
             </CSSTransition>
         </SwitchTransition>

packages/flat-components/src/containers/CloudStorageContainer/index.tsx

@@ -78,10 +78,10 @@ export const CloudStorageContainer = observer<CloudStorageContainerProps>(
                     </div>
                 )}
                 <div className="cloud-storage-container-file-list fancy-scrollbar">
-                    {!store.totalUsageHR ? (
-                        <CloudStorageSkeletons isCompactMode={store.compact} />
-                    ) : (
+                    {store.totalUsageHR ? (
                         <CloudStorageFileListContainer store={store} />
+                    ) : (
+                        <CloudStorageSkeletons isCompactMode={store.compact} />
                     )}
                 </div>
                 <CSSTransition

web/flat-web/src/api-middleware/Rtm.ts

@@ -352,7 +352,18 @@ export class Rtm extends EventEmitter<keyof RTMEvents> {
             return;
         }
 
-        if (peerId !== undefined) {
+        if (peerId === undefined) {
+            await this.commands.sendMessage(
+                {
+                    messageType: AgoraRTM.MessageType.TEXT,
+                    text: JSON.stringify({ t: type, v: value }),
+                },
+                { enableHistoricalMessaging: keepHistory },
+            );
+            if (NODE_ENV === "development") {
+                console.log("[RTM] send group command: ", type, value);
+            }
+        } else {
             await polly()
                 .waitAndRetry(retry)
                 .executeForPromise(async (): Promise<void> => {
@@ -371,17 +382,6 @@ export class Rtm extends EventEmitter<keyof RTMEvents> {
                         return Promise.reject("peer not received");
                     }
                 });
-        } else {
-            await this.commands.sendMessage(
-                {
-                    messageType: AgoraRTM.MessageType.TEXT,
-                    text: JSON.stringify({ t: type, v: value }),
-                },
-                { enableHistoricalMessaging: keepHistory },
-            );
-            if (NODE_ENV === "development") {
-                console.log("[RTM] send group command: ", type, value);
-            }
         }
     }