Skip CLI session expired notifcation if notifications are disabled (#3266)

lixmal · web-flow · commit d7d5b1b1d608 · 2025-02-20T15:01:53.000+01:00
diff --git a/client/server/server.go b/client/server/server.go
@@ -766,10 +766,11 @@ func (s *Server) GetConfig(_ context.Context, _ *proto.GetConfigRequest) (*proto
 		DisableNotifications: s.config.DisableNotifications,
 	}, nil
 }
+
 func (s *Server) onSessionExpire() {
 	if runtime.GOOS != "windows" {
 		isUIActive := internal.CheckUIApp()
-		if !isUIActive {
+		if !isUIActive && !s.config.DisableNotifications {
 			if err := sendTerminalNotification(); err != nil {
 				log.Errorf("send session expire terminal notification: %v", err)
 			}

Original file line number	Diff line number	Diff line change
`@@ -766,10 +766,11 @@ func (s Server) GetConfig(_ context.Context, _ proto.GetConfigRequest) (*proto`
`766`	`766`	`DisableNotifications: s.config.DisableNotifications,`
`767`	`767`	`}, nil`
`768`	`768`	`}`
	`769`	`+`
`769`	`770`	`func (s *Server) onSessionExpire() {`
`770`	`771`	`if runtime.GOOS != "windows" {`
`771`	`772`	`isUIActive := internal.CheckUIApp()`
`772`		`- if !isUIActive {`
	`773`	`+ if !isUIActive && !s.config.DisableNotifications {`
`773`	`774`	`if err := sendTerminalNotification(); err != nil {`
`774`	`775`	`log.Errorf("send session expire terminal notification: %v", err)`
`775`	`776`	`}`