-
Notifications
You must be signed in to change notification settings - Fork 30
fix: Handle KeyError in W&B migration script and add validation for missing Neptune workspace
#361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing Neptune workspace
Reviewer's guide (collapsed on small PRs)Reviewer's GuideEnhance robustness of the W&B to Neptune migration script by validating the Neptune workspace input and extending error handling in metric copying to include KeyError. Sequence diagram for Neptune workspace name validation in migration scriptsequenceDiagram
actor User
participant Script
User->>Script: Start migration script
Script->>User: Prompt for Neptune workspace name
User->>Script: Enter workspace name
Script->>Script: Validate workspace name
alt Workspace name is empty
Script->>User: Print error message
Script->>Script: Exit with error
else Workspace name is valid
Script->>Script: Continue execution
end
Class diagram for updated error handling in copy_metrics functionclassDiagram
class copy_metrics {
+copy_metrics(neptune_run, wandb_run)
- Handles IndexError, TypeError, KeyError when copying metrics
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `utils/migration_tools/from_wandb/wandb_to_neptune.py:236` </location>
<code_context>
): # Not uploading W&B table-file to Neptune
continue
- except (IndexError, TypeError):
+ except (IndexError, TypeError, KeyError):
if epoch:
neptune_run[key].append(value, step=epoch)
</code_context>
<issue_to_address>
**issue (bug_risk):** Adding KeyError to the exception handling may mask unexpected issues.
If missing keys are expected, handle them explicitly or log them for debugging.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
LeoRoccoBreedt
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the changes and the related issue.
Related to: <ClickUp/JIRA task name>
Any expected test failures?
Add a
[X]to relevant checklist items❔ This change
✔️ Pre-merge checklist
🧪 Test Configuration
Summary by Sourcery
Validate Neptune workspace input and extend exception handling in the W&B-to-Neptune migration script to catch KeyError and avoid crashes.
Bug Fixes: