Skip to content

Handle getting summary in Testkit Backend when a Record Iterator exists #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025
+5 −1
Merged

Handle getting summary in Testkit Backend when a Record Iterator exists #1258

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7381faf
handle getting summary when a recorditerator exists
MaxAake Feb 17, 2025
032fe93
remove logging
MaxAake Feb 18, 2025
e18e353
DRYing up the solution
MaxAake Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/testkit-backend/src/request-handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,14 @@ export function ResultConsume (_, context, data, wire) {
const { resultId } = data
const result = context.getResult(resultId)

if (('recordIt' in result)) {
return result.recordIt.return().then(summary => {
if (summary.value) {
summary = summary.value
}
wire.writeResponse(responses.Summary({ summary }, { binder: context.binder }))
}).catch(e => wire.writeError(e))
}
return result.summary().then(summary => {
wire.writeResponse(responses.Summary({ summary }, { binder: context.binder }))
}).catch(e => wire.writeError(e))
Expand Down
1 change: 1 addition & 0 deletions packages/testkit-backend/src/skipped-tests/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const skippedTests = [
skip(
'ResultSummary.notifications defaults to empty array instead of return null/undefined',
ifEquals('stub.summary.test_summary.TestSummaryNotifications4x4.test_no_notifications'),
ifEquals('stub.summary.test_summary.TestSummaryNotifications4x4Discard.test_no_notifications'),
ifEquals('neo4j.test_summary.TestSummary.test_no_notification_info')
),
skip(
Expand Down