Fix GetAndChange warnings (#3702)

shargon · web-flow · commit 805678d9f745 · 2025-01-30T03:00:37.000-08:00
* Fix warnings

* Update src/Neo/Persistence/DataCache.cs
diff --git a/src/Neo/Persistence/DataCache.cs b/src/Neo/Persistence/DataCache.cs
@@ -316,7 +316,7 @@ public bool Contains(StorageKey key)
         /// <param name="key">The key of the entry.</param>
         /// <param name="factory">A delegate used to create the entry if it doesn't exist. If the entry already exists, the factory will not be used.</param>
         /// <returns>The cached data. Or <see langword="null"/> if it doesn't exist and the <paramref name="factory"/> is not provided.</returns>
-        public StorageItem? GetAndChange(StorageKey key, Func<StorageItem>? factory = null)
+        public StorageItem? GetAndChange(StorageKey key, [NotNullIfNotNull(nameof(factory))] Func<StorageItem>? factory = null)
         {
             lock (_dictionary)
             {

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ public bool Contains(StorageKey key)`
`316`	`316`	`/// <param name="key">The key of the entry.</param>`
`317`	`317`	`/// <param name="factory">A delegate used to create the entry if it doesn't exist. If the entry already exists, the factory will not be used.</param>`
`318`	`318`	`/// <returns>The cached data. Or <see langword="null"/> if it doesn't exist and the <paramref name="factory"/> is not provided.</returns>`
`319`		`- public StorageItem? GetAndChange(StorageKey key, Func<StorageItem>? factory = null)`
	`319`	`+ public StorageItem? GetAndChange(StorageKey key, [NotNullIfNotNull(nameof(factory))] Func<StorageItem>? factory = null)`
`320`	`320`	`{`
`321`	`321`	`lock (_dictionary)`
`322`	`322`	`{`