-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade react-scripts from 4.0.1 to 4.0.3 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3. See this package in npm: react-scripts See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/8b459f2e-82b2-4c7d-9100-f989edb837b9?utm_source=github&utm_medium=referral&page=upgrade-pr
Summary of ChangesHello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the project's security posture by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR is a good security improvement, upgrading react-scripts to 4.0.3 to fix multiple vulnerabilities. However, there's a critical issue: the package-lock.json file is missing from this PR. Without it, the dependency update will not take effect in CI/CD environments. Please run npm install and commit the updated package-lock.json. I've also added a suggestion to use a caret (^) for the version to automatically get future patches. Lastly, please consider planning an upgrade to react-scripts v5, as v4 is no longer actively maintained.
| "react": "^17.0.1", | ||
| "react-dom": "^17.0.1", | ||
| "react-scripts": "4.0.1" | ||
| "react-scripts": "4.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While pinning the version ensures stability, using a caret (^) for react-scripts (i.e., ^4.0.3) is generally recommended. This allows npm to automatically install future patch releases, which often include important security fixes and bug fixes, without introducing breaking changes. Since other dependencies like react and react-dom already use carets, it would be consistent to do the same here.
| "react-scripts": "4.0.3" | |
| "react-scripts": "^4.0.3" |
Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 2 versions ahead of your current version.
The recommended version was released 5 years ago.
Issues fixed by the recommended upgrade:
SNYK-JS-ASYNC-2441827
SNYK-JS-BODYPARSER-7926860
SNYK-JS-FOLLOWREDIRECTS-6141137
SNYK-JS-DNSPACKET-1293563
SNYK-JS-IMMER-1019369
SNYK-JS-IP-6240864
SNYK-JS-URLPARSE-2407770
SNYK-JS-EVENTSOURCE-2823375
SNYK-JS-EXPRESS-6474509
SNYK-JS-EXPRESS-7926867
SNYK-JS-FOLLOWREDIRECTS-2332181
SNYK-JS-BABELTRAVERSE-5962462
SNYK-JS-FOLLOWREDIRECTS-6444610
SNYK-JS-COOKIE-8163060
SNYK-JS-ONHEADERS-10773729
SNYK-JS-PATHTOREGEXP-7925106
SNYK-JS-PATHTOREGEXP-8482416
SNYK-JS-REACTDEVUTILS-1083268
SNYK-JS-URLPARSE-1078283
SNYK-JS-URLPARSE-1533425
SNYK-JS-URLPARSE-2401205
SNYK-JS-URLPARSE-2407759
SNYK-JS-URLPARSE-2412697
SNYK-JS-FOLLOWREDIRECTS-2396346
SNYK-JS-SEND-7926862
SNYK-JS-SERVESTATIC-7926865
Release notes
Package name: react-scripts
-
4.0.3 - 2021-02-22
-
4.0.2 - 2021-02-03
-
4.0.1 - 2020-11-23
from react-scripts GitHub release notesImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: