Fix page margins and gaps #30995
Merged
Fix page margins and gaps #30995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes no sense to define this width from configutation()->borderWidth() cause that's a value for UI logical pixels (and it's just equal to 1), but this painter operates in notation units determined by mu::engraving::DPI (and scales when zooming on the score). The correct thing is to define it in millimetres (0.07mm turns out to be the corresponding value).
cbjeukendrup
approved these changes
Nov 12, 2025
| const double strokeWidth = 0.07 * DPMM; | ||
| painter->setBrush(BrushStyle::NoBrush); | ||
| painter->setPen(Pen(configuration()->borderColor(), configuration()->borderWidth())); | ||
| painter->setPen(Pen(configuration()->borderColor(), strokeWidth)); |
Member
There was a problem hiding this comment.
I wonder if there are any other places where NotationConfiguration::borderWidth is used that need the same treatment
Contributor
Author
There was a problem hiding this comment.
From a quick search, it doesn't seems so (as in, borderWidth appears everywhere but not in other bits of notation painting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30986