-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Windows application manifest #30886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7c4d375 to
ade3034
Compare
|
@DmitryArefiev This one only needs testing on Windows. Just a small regression check; maybe the following things:
|
| @@ -0,0 +1,41 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please move this file to app/configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
The manifest contains four things:
- declare compatibility with Windows 10 & 11
- we were running inside a Windows Vista compatibility context before
- set process DPI awareness to PerMonitorV2
- this is already set by Qt programmatically at start up
- use v6 instead of v5 of the CommonControls library
- enable modern styles in system dialogs
- user account control settings
- for completeness. The linker adds that by default anyway, so this
was already part of the executable
This effectively reverts fb63d3e
ade3034 to
d1d4b6e
Compare
The manifest contains five things:
The compatibility declaration with Windows 10 & 11 might change behavior or might not. (I don't expect any changes in behavior)
Another thing we could do is set the process's codepage to UTF-81. This might allow as to drop this call toQTextCodec::setCodecForLocalefrom Qt6Core5Compat.Print dialog with Windows 10:
Footnotes
https://learn.microsoft.com/en-us/windows/win32/sbscs/application-manifests#activecodepage ↩