-
Notifications
You must be signed in to change notification settings - Fork 3k
Independent style settings for slurs and ties #20693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like one MusicXML unit test still desires to be updated... |
|
The test seems to fail on every mxl test file, but I don't see any issues with my code or the test's code. Do the test files need to be updated? |
|
Yes, in this case the test file needs to be updated. (Note that the diff shown in the test output may feel like it's the wrong way around, so the "+" lines are what's currently in the reference file and the "-" lines are what it needs to become.) |
bkunda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks fine to me.
If I were to nitpick about a tiny UI issue, there should be a gap between the bottom of the "Slurs & Ties" section and the top of the "Ties" section.
The "System" page has what looks to be roughly 12px of padding here (perhaps this could be used as a reference).
Otherwise it's great! Thanks @XiaoMigros!
|
Thanks for the feedback @bkunda! The layout now matches that of other pages in the dialog. I also changed |
77c8574 to
2424591
Compare
279cda5 to
736d658
Compare
This comment was marked as outdated.
This comment was marked as outdated.
736d658 to
40cf5b5
Compare
|
I've given this another test on macOS. Only thing I noticed was that modifying settings for Slurs seemed to affect my ties as well. At the same time, modifying "Line thickness middle" for ties didn't have any affect at all. See video |
40cf5b5 to
818561a
Compare
|
Another rebase is needed since the recent work in the MusicXML module... |
818561a to
4ae5a98
Compare
|
From the combination of Bradley's latest comment and Simon's approval after the last fix, I assume that this is ready for merging, right? |
* Independent style settings for slurs and ties Backport of musescore#20693 * Update translations --------- Co-authored-by: XiaoMigros <[email protected]>
Resolves: #18769
This PR introduces separate style settings for slurs and ties, with accompanying UI changes to the style dialog.