Skip to content

Introduce separate line width style for tab bends #20242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

Introduce separate line width style for tab bends #20242

merged 1 commit into from
Dec 5, 2023

Conversation

@mike-spa
Copy link
Contributor

@mike-spa mike-spa commented Nov 29, 2023

...and change the Bend style menu accordingly.

@mike-spa mike-spa force-pushed the separateLineWidthForTabBends branch 2 times, most recently from a70c4c6 to c59a9b7 Compare November 29, 2023 13:15
@its-not-nice its-not-nice added engraving Shape, position, or ability to notate musical symbols & text in the score P2 Priority: Medium and removed P2 Priority: Medium labels Nov 29, 2023
its-not-nice
its-not-nice reviewed Nov 29, 2023
View reviewed changes
@mike-spa mike-spa force-pushed the separateLineWidthForTabBends branch from c59a9b7 to 54f1d37 Compare November 29, 2023 15:26
@its-not-nice its-not-nice added the vtests This PR produces approved changes to vtest results label Nov 29, 2023
bkunda
bkunda requested changes Nov 30, 2023
View reviewed changes
Copy link

@bkunda bkunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls just adjust the spin box for Standard Stave Line Thickness to adjust in 0.1 increments, rather than 1.0 See video

@mike-spa mike-spa force-pushed the separateLineWidthForTabBends branch from 54f1d37 to f5f5731 Compare November 30, 2023 16:00
@mike-spa
Copy link
Contributor Author

mike-spa commented Nov 30, 2023

I think 0.1 is still way too coarse (a single +- 0.1 click already brings the values into unreasonable territory). So I actually made it 0.01, which feels better (and the reasonable territory is just few clicks away in either direction)

@mike-spa mike-spa requested a review from bkunda November 30, 2023 16:14
bkunda
bkunda approved these changes Dec 5, 2023
View reviewed changes
Copy link

@bkunda bkunda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS. FIXED:

@cbjeukendrup cbjeukendrup merged commit de94256 into musescore:master Dec 5, 2023
@RomanPudashkin RomanPudashkin mentioned this pull request Dec 11, 2023
Merged
@mike-spa mike-spa deleted the separateLineWidthForTabBends branch February 17, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@its-not-nice its-not-nice its-not-nice approved these changes

@cbjeukendrup cbjeukendrup cbjeukendrup approved these changes

@bkunda bkunda bkunda approved these changes

Assignees

No one assigned

Labels

engraving Shape, position, or ability to notate musical symbols & text in the score vtests This PR produces approved changes to vtest results

Projects

No open projects
MuseScore 4.2
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mike-spa @its-not-nice @cbjeukendrup @bkunda