fix: add interface files to the exports map #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interfaces from the interface files in this module are [imported](https://github.com/ipld/js-dag-cbor/blob/master/src/index.js#L9) in other modules, so they need to be in the exports map otherwise tsc can fail to build dependant modules.
|
There's a repro of the problem this solves here: https://github.com/thehenrytsai/dag-cbor-import-repro Just |
rvagg
approved these changes
Mar 8, 2023
Yeah - if skipLibCheck is |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 9, 2023
## [11.0.2](v11.0.1...v11.0.2) (2023-03-09) ### Bug Fixes * add interface files to the exports map ([#246](#246)) ([a58a398](a58a398)), closes [/github.com/ipld/js-dag-cbor/blob/master/src/index.js#L9](https://github.com/multiformats//github.com/ipld/js-dag-cbor/blob/master/src/index.js/issues/L9)
|
🎉 This PR is included in version 11.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interfaces from the interface files in this module are imported in other modules, so they need to be in the exports map otherwise tsc can fail to build dependant modules.