Reanable tsc action and reconfigure project slightly #157
Conversation
package.json
Outdated
| "test:esm:browser": "polendina --page --worker --serviceworker --cleanup dist/esm/browser-test/test-*.js", | ||
| "test:ts": "npm run build:types && npm run test --prefix test/ts-use", | ||
| "test": "npm run lint && npm run test:node && npm run test:esm && npm run test:ts", | ||
| "typecheck": "tsc --build test/tsconfig.json", |
There was a problem hiding this comment.
Does it get run by the gozala/typescript-error-reporter-action? If not, then I don't think this gets run by anything automatically, or manually unless someone runs it directly, is it?
Let's wire this up to one of the main scripts that devs will be using- maybe just add it in to "test", "build:types" would also work but it's not really a "build" script per se.
There was a problem hiding this comment.
I just mostly added for convenience so I could run npm run typecheck, it should not create build artifacts because tsconfig.json has noEmit. I wish there was tsc check but sadly TS is not exactly what some would wish for.
I can remove this
This is fine by me but I just didn't really want to take responsibility for changing the complicated layout we have since it's getting quite complex and fragile! Otherwise I just have that one question inline about |
I wish there was simpler way to accomplish this. Never the less I think this does simplify config(s) which I hope should make things a bit less fragile, even if it introduces one extra directory because it removes opportunity from a random file to reshape directory layout again in the future. From the comment I assume it is ok to land, so I'm going to proceed as I would like to submit another PR and would like to avoid rebasing things over. |
### [9.5.9](v9.5.8...v9.5.9) (2022-01-18) ### Trivial Changes * Reanable tsc action and reconfigure project slightly ([#157](#157)) ([c936a6d](c936a6d))
|
🎉 This PR is included in version 9.5.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
This pull reverts b0467e5 which reports type errors in the diff view as opposed to just dumping it into output.
It also changes TS configuration as follows:
src. As it turns outcompositeflag in tsconfig causes dir stracture to be retained & that flag is necessary to enable project references. We do not however generate types for tests though because those aren't included.