Skip to content

Commit f20a8fc

Browse files
[core] Fix missing context display names (#12124)
1 parent 8a88e22 commit f20a8fc

File tree

14 files changed

+55
-22
lines changed

14 files changed

+55
-22
lines changed

packages/x-charts/src/ChartsOnAxisClickHandler/ChartsOnAxisClickHandler.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22
import PropTypes from 'prop-types';
3-
import { SVGContext } from '../context/DrawingProvider';
3+
import { SvgContext } from '../context/DrawingProvider';
44
import { InteractionContext } from '../context/InteractionProvider';
55
import { CartesianContext } from '../context/CartesianContextProvider';
66
import { SeriesContext } from '../context/SeriesContextProvider';
@@ -24,7 +24,7 @@ export interface ChartsOnAxisClickHandlerProps {
2424
function ChartsOnAxisClickHandler(props: ChartsOnAxisClickHandlerProps) {
2525
const { onAxisClick } = props;
2626

27-
const svgRef = React.useContext(SVGContext);
27+
const svgRef = React.useContext(SvgContext);
2828
const series = React.useContext(SeriesContext);
2929
const { axis } = React.useContext(InteractionContext);
3030
const { xAxisIds, xAxis, yAxisIds, yAxis } = React.useContext(CartesianContext);

packages/x-charts/src/ChartsTooltip/utils.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22
import { AxisInteractionData, ItemInteractionData } from '../context/InteractionProvider';
3-
import { SVGContext } from '../context/DrawingProvider';
3+
import { SvgContext } from '../context/DrawingProvider';
44
import {
55
CartesianChartSeriesType,
66
ChartSeriesDefaultized,
@@ -41,7 +41,7 @@ export function generateVirtualElement(mousePosition: { x: number; y: number } |
4141
}
4242

4343
export function useMouseTracker() {
44-
const svgRef = React.useContext(SVGContext);
44+
const svgRef = React.useContext(SvgContext);
4545

4646
// Use a ref to avoid rerendering on every mousemove event.
4747
const [mousePosition, setMousePosition] = React.useState<null | { x: number; y: number }>(null);

packages/x-charts/src/ChartsVoronoiHandler/ChartsVoronoiHandler.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Delaunay } from 'd3-delaunay';
44
import useEnhancedEffect from '@mui/utils/useEnhancedEffect';
55
import { InteractionContext } from '../context/InteractionProvider';
66
import { CartesianContext } from '../context/CartesianContextProvider';
7-
import { SVGContext, DrawingContext } from '../context/DrawingProvider';
7+
import { SvgContext, DrawingContext } from '../context/DrawingProvider';
88
import { SeriesContext } from '../context/SeriesContextProvider';
99
import { getValueToPositionMapper } from '../hooks/useScale';
1010
import { getSVGPoint } from '../internals/utils';
@@ -27,7 +27,7 @@ export type ChartsVoronoiHandlerProps = {
2727

2828
function ChartsVoronoiHandler(props: ChartsVoronoiHandlerProps) {
2929
const { voronoiMaxRadius, onItemClick } = props;
30-
const svgRef = React.useContext(SVGContext);
30+
const svgRef = React.useContext(SvgContext);
3131
const { width, height, top, left } = React.useContext(DrawingContext);
3232
const { xAxis, yAxis, xAxisIds, yAxisIds } = React.useContext(CartesianContext);
3333
const { dispatch } = React.useContext(InteractionContext);

packages/x-charts/src/Gauge/GaugeProvider.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,10 @@ export const GaugeContext = React.createContext<
125125
valueAngle: null,
126126
});
127127

128+
if (process.env.NODE_ENV !== 'production') {
129+
GaugeContext.displayName = 'GaugeContext';
130+
}
131+
128132
export interface GaugeProviderProps extends GaugeConfig, CircularConfig {
129133
children: React.ReactNode;
130134
}

packages/x-charts/src/context/CartesianContextProvider.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,10 @@ export const CartesianContext = React.createContext<{
9090
// @ts-ignore
9191
}>({ xAxis: {}, yAxis: {}, xAxisIds: [], yAxisIds: [] });
9292

93+
if (process.env.NODE_ENV !== 'production') {
94+
CartesianContext.displayName = 'CartesianContext';
95+
}
96+
9397
function CartesianContextProvider(props: CartesianContextProviderProps) {
9498
const { xAxis: inXAxis, yAxis: inYAxis, dataset, children } = props;
9599
const formattedSeries = React.useContext(SeriesContext);

packages/x-charts/src/context/DrawingProvider.tsx

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,18 @@ export const DrawingContext = React.createContext<
5454
width: 400,
5555
chartId: '',
5656
});
57-
export const SVGContext = React.createContext<React.RefObject<SVGSVGElement>>({ current: null });
5857

59-
function DrawingProvider(props: DrawingProviderProps) {
58+
if (process.env.NODE_ENV !== 'production') {
59+
DrawingContext.displayName = 'DrawingContext';
60+
}
61+
62+
export const SvgContext = React.createContext<React.RefObject<SVGSVGElement>>({ current: null });
63+
64+
if (process.env.NODE_ENV !== 'production') {
65+
SvgContext.displayName = 'SvgContext';
66+
}
67+
68+
export function DrawingProvider(props: DrawingProviderProps) {
6069
const { width, height, margin, svgRef, children } = props;
6170
const drawingArea = useChartDimensions(width, height, margin);
6271
const chartId = useId();
@@ -67,10 +76,8 @@ function DrawingProvider(props: DrawingProviderProps) {
6776
);
6877

6978
return (
70-
<SVGContext.Provider value={svgRef}>
79+
<SvgContext.Provider value={svgRef}>
7180
<DrawingContext.Provider value={value}>{children}</DrawingContext.Provider>
72-
</SVGContext.Provider>
81+
</SvgContext.Provider>
7382
);
7483
}
75-
76-
export { DrawingProvider };

packages/x-charts/src/context/HighlightProvider.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,10 @@ export const HighlighContext = React.createContext<HighlighState>({
5656
dispatch: () => null,
5757
});
5858

59+
if (process.env.NODE_ENV !== 'production') {
60+
HighlighContext.displayName = 'HighlighContext';
61+
}
62+
5963
const dataReducer: React.Reducer<Omit<HighlighState, 'dispatch'>, HighlighActions> = (
6064
prevState,
6165
action,

packages/x-charts/src/context/InteractionProvider.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ export const InteractionContext = React.createContext<InteractionState>({
6363
dispatch: () => null,
6464
});
6565

66+
if (process.env.NODE_ENV !== 'production') {
67+
InteractionContext.displayName = 'InteractionContext';
68+
}
69+
6670
const dataReducer: React.Reducer<Omit<InteractionState, 'dispatch'>, InteractionActions> = (
6771
prevState,
6872
action,

packages/x-charts/src/context/SeriesContextProvider.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ export type FormattedSeries = { [type in ChartSeriesType]?: FormatterResult<type
3434

3535
export const SeriesContext = React.createContext<FormattedSeries>({});
3636

37+
if (process.env.NODE_ENV !== 'production') {
38+
SeriesContext.displayName = 'SeriesContext';
39+
}
40+
3741
const seriesTypeFormatter: {
3842
[type in ChartSeriesType]?: (series: any, dataset?: DatasetType) => any;
3943
} = {

packages/x-charts/src/hooks/useAxisEvents.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as React from 'react';
22
import { InteractionContext } from '../context/InteractionProvider';
33
import { CartesianContext } from '../context/CartesianContextProvider';
4-
import { SVGContext, DrawingContext } from '../context/DrawingProvider';
4+
import { SvgContext, DrawingContext } from '../context/DrawingProvider';
55
import { isBandScale } from '../internals/isBandScale';
66
import { AxisDefaultized } from '../models/axis';
77
import { getSVGPoint } from '../internals/utils';
@@ -10,7 +10,7 @@ function getAsANumber(value: number | Date) {
1010
return value instanceof Date ? value.getTime() : value;
1111
}
1212
export const useAxisEvents = (disableAxisListener: boolean) => {
13-
const svgRef = React.useContext(SVGContext);
13+
const svgRef = React.useContext(SvgContext);
1414
const { width, height, top, left } = React.useContext(DrawingContext);
1515
const { xAxis, yAxis, xAxisIds, yAxisIds } = React.useContext(CartesianContext);
1616
const { dispatch } = React.useContext(InteractionContext);

0 commit comments

Comments
 (0)