[Switch] Add role="switch" #46482
Merged
[Switch] Add role="switch" #46482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
accessibility
Netlify deploy previewBundle size report
|
1 task
sai6855
approved these changes
Jul 4, 2025
yafeng-c
pushed a commit
to yafeng-c/material-ui
that referenced
this pull request
Jul 5, 2025
[Switch] Add role="switch" (mui#46482) fix again update new tests
Member
|
To note that this change breaks tests like: screen.getByRole('checkbox', { name: 'Pivot' });that depends on being a specific role. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23216
Adds
role="switch"to the input element to improve accessibility.Tested with NVDA—now announces "on/off" instead of "checked/unchecked".