[core][Modal] Replace show parameter name with hide in modal manager
#43868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
scope: modal
Netlify deploy previewhttps://deploy-preview-43868--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
requested review from
DiegoAndai,
aarongarciah and
michaldudak
aarongarciah
approved these changes
Sep 26, 2024
oliviertassinari
added
the
internal
oliviertassinari
changed the title
show parameter name with hide in modal managershow parameter name with hide in modal manager
This was referenced Oct 25, 2024
This was referenced Oct 29, 2024
This was referenced Oct 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing a PR I noticed the parameter name
showis confusing becausearia-hiddenshould be set to true whenhideis true, hiding the element from the accessibility tree. This PR renames the parameter fromshowtohidefor clarity.