Skip to content

Conversation

@Jay-Karia
Copy link
Contributor

This PR add a missing link to mui-joi package's source code.

Closes #43177

@mui-bot
Copy link

mui-bot commented Aug 4, 2024

Netlify deploy preview

https://deploy-preview-43178--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8c8b965

@oliviertassinari
Copy link
Member

I don't think that we should merge this, but instead close and solve #36824.

If we really want to move forward, the link should be fixed to not be branch dependant, and Material UI MD2 should have equivalent treatment to Material UI Joy.

@Jay-Karia
Copy link
Contributor Author

@oliviertassinari I would love to contribute there. #36824 👍

@zannager zannager added the docs Improvements or additions to the documentation. label Aug 5, 2024
@mapache-salvaje mapache-salvaje changed the title chore(docs): add missing joy-ui link [docs] Add Joy UI source code link to README Aug 21, 2024
@mapache-salvaje
Copy link
Contributor

I'm going to close this now that we have #43387 in the works. I think the approach to documenting Joy UI in the @mui/material readme needs to be reconsidered. I'll open a separate PR to suggest changes.

@Jay-Karia Jay-Karia deleted the docs/missing-link branch August 21, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs]: missing joy-ui GitHub link

5 participants