[autocomplete] Avoid spread operator #40968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
scope: autocomplete
1 task
oliviertassinari
force-pushed
the
autocomplete
branch
from
cf0decc to
1ed9af3
Compare
Netlify deploy previewhttps://deploy-preview-40968--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
romgrk
reviewed
Feb 7, 2024
Comment on lines
+557
to
+559
| // Need to clearly apply key because of https://github.com/vercel/next.js/issues/55642 | ||
| return ( | ||
| <li key={key} {...otherProps}> | ||
| <li {...props2} key={props2.key}> |
Contributor
There was a problem hiding this comment.
I've read the issue but I still can't wrap my head around what the cause is.
And yeah from a performance POV, using the spread operator is always bad, so for leaf elements it can be better to not use it. An easy escape hatch when one is simply transfering props could be to use directly React.createElement('li', props2, children).
This was referenced May 15, 2024
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick follow-up on #39795 (comment). Adding comments to people in the future can figure out if this logic is still needed. And tried to speed up a bit the rendering.
To be noted that the problem isn't completely solved, the demos we have in the docs are 🙃
One iteration on #39833