Skip to content

Conversation

@fullstackzach
Copy link
Contributor

@fullstackzach fullstackzach commented Jul 27, 2022

While migrating to Material UI v5, we found the reference to the docs here were incorrectly referring to Pagination, but it should actually be usePagination, and usePagination should be a default import

Preview: https://deploy-preview-33675--material-ui.netlify.app/material-ui/react-pagination/#usepagination

While migrating to Material UI v5, we found the reference to the docs here were incorrectly referring to `Pagination`, but it should actually be `usePagination`
@mui-bot
Copy link

mui-bot commented Jul 27, 2022

No bundle size changes

Generated by 🚫 dangerJS against 8086435

@fullstackzach fullstackzach changed the title Docs: Update module reference for usePagination [docs] Update module reference for usePagination Jul 27, 2022
usePagination is also a default import
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Update module reference for usePagination [docs] Update module reference for usePagination Jul 28, 2022
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation. scope: pagination Changes related to the pagination. type: bug It doesn't behave as expected. labels Jul 28, 2022
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great first pull request on Material UI 👌 Thank you for working on it!

@ZeeshanTamboli ZeeshanTamboli merged commit 62d8a93 into mui:master Jul 28, 2022
@fullstackzach fullstackzach deleted the patch-1 branch July 28, 2022 15:52
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
* Update module reference for usePagination

While migrating to Material UI v5, we found the reference to the docs here were incorrectly referring to `Pagination`, but it should actually be `usePagination`

* docs: usePagination should be a default import

usePagination is also a default import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: pagination Changes related to the pagination. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants