Skip to content

Conversation

@b-novikov-ipersonality
Copy link
Contributor

@b-novikov-ipersonality b-novikov-ipersonality commented Apr 29, 2022

closes #32490

Adds sx prop to TabIndicatorProps type

@mui-bot
Copy link

mui-bot commented Apr 29, 2022

No bundle size changes

Generated by 🚫 dangerJS against 563af76

@siriwatknp siriwatknp added the PR: needs test The pull request needs tests. label Apr 29, 2022
@siriwatknp
Copy link
Member

@b-novikov-ipersonality Please add a test to packages/mui-material/src/Tabs/Tabs.spec.tsx. It is the file for testing that typings are working.

@siriwatknp siriwatknp added scope: tabs Changes related to the tabs. typescript labels Apr 29, 2022
@b-novikov-ipersonality
Copy link
Contributor Author

@siriwatknp added the test

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your first contribution!

@ZeeshanTamboli ZeeshanTamboli removed the PR: needs test The pull request needs tests. label Apr 29, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title fix: TabIndicatorProps component missing sx prop [Tabs] Fix TabIndicatorProps prop missing sx prop Apr 29, 2022
@siriwatknp siriwatknp merged commit 4d49b7a into mui:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: tabs Changes related to the tabs. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TabIndicatorProps prop on Tabs component is missing sx prop

5 participants