-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
Description
Awesome job guys. Been using this in beta, and so far I'm quite pleased with the changes in 1.0. Works really well so far.
Noticing the drawer attaches itself outside of the hierarchy it was placed in and decides to attach itself to the top level of the dom. This makes doing things like relative positioning to its containing element impossible (without hacks). This behavior might be convenient at first, but is relatively inconsistent.
This should instead be a child of the element it is placed in, and if I actually want it to be relative to the most outmost container, I would place it there, with explicit positioning via css overrides.
Seems like you can kind of overload this behavior via ModalProps and overriding the container, but seems like that won't work initially since the element seems like it has to already exist to override? So you can get it to work, but then you'll need to do hackey things via refs and rerendering once the div has been mounted to the dom, and that's always kind of tacky.
material-ui/core": "^1.0.0"