Skip to content

Commit e271861

Browse files
[core] Avoid popper.js npm warning (#20433)
* [core] Avoid popper.js warning * [core] Use lts
1 parent cab2eee commit e271861

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

packages/material-ui/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"@types/react-transition-group": "^4.2.0",
5656
"clsx": "^1.0.2",
5757
"hoist-non-react-statics": "^3.3.2",
58-
"popper.js": "^1.14.1",
58+
"popper.js": "^1.16.1-lts",
5959
"prop-types": "^15.7.2",
6060
"react-is": "^16.8.0",
6161
"react-transition-group": "^4.3.0"

packages/material-ui/src/Popper/Popper.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22
import PropTypes from 'prop-types';
3-
import PopperJS from 'popper.js';
3+
import PopperJs from 'popper.js';
44
import { chainPropTypes, refType } from '@material-ui/utils';
55
import { useTheme } from '@material-ui/styles';
66
import Portal from '../Portal';
@@ -123,7 +123,7 @@ const Popper = React.forwardRef(function Popper(props, ref) {
123123
}
124124
}
125125

126-
const popper = new PopperJS(getAnchorEl(anchorEl), tooltipRef.current, {
126+
const popper = new PopperJs(getAnchorEl(anchorEl), tooltipRef.current, {
127127
placement: rtlPlacement,
128128
...popperOptions,
129129
modifiers: {

packages/material-ui/src/Popper/Popper.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { ThemeProvider, createMuiTheme } from '@material-ui/core/styles';
77
import describeConformance from '@material-ui/core/test-utils/describeConformance';
88
import { createClientRender } from 'test/utils/createClientRender';
99
import consoleErrorMock from 'test/utils/consoleErrorMock';
10-
import PopperJS from 'popper.js';
10+
import PopperJs from 'popper.js';
1111
import Grow from '../Grow';
1212
import Popper from './Popper';
1313

@@ -238,12 +238,12 @@ describe('<Popper />', () => {
238238
const ref1 = React.createRef();
239239
const ref2 = React.createRef();
240240
const wrapper = mount(<Popper {...defaultProps} popperRef={ref1} />);
241-
assert.strictEqual(ref1.current instanceof PopperJS, true);
241+
assert.strictEqual(ref1.current instanceof PopperJs, true);
242242
wrapper.setProps({
243243
popperRef: ref2,
244244
});
245245
assert.strictEqual(ref1.current, null);
246-
assert.strictEqual(ref2.current instanceof PopperJS, true);
246+
assert.strictEqual(ref2.current instanceof PopperJs, true);
247247
});
248248
});
249249

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12414,10 +12414,10 @@ [email protected]:
1241412414
dependencies:
1241512415
ts-pnp "^1.1.2"
1241612416

12417-
popper.js@^1.14.1:
12418-
version "1.16.0"
12419-
resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.16.0.tgz#2e1816bcbbaa518ea6c2e15a466f4cb9c6e2fbb3"
12420-
integrity sha512-+G+EkOPoE5S/zChTpmBSSDYmhXJ5PsW8eMhH8cP/CQHMFPBG/kC9Y5IIw6qNYgdJ+/COf0ddY2li28iHaZRSjw==
12417+
popper.js@^1.16.1-lts:
12418+
version "1.16.1"
12419+
resolved "https://registry.yarnpkg.com/popper.js/-/popper.js-1.16.1.tgz#2a223cb3dc7b6213d740e40372be40de43e65b1b"
12420+
integrity sha512-Wb4p1J4zyFTbM+u6WuO4XstYx4Ky9Cewe4DWrel7B0w6VVICvPwdOpotjzcf6eD8TsckVnIMNONQyPIUFOUbCQ==
1242112421

1242212422
posix-character-classes@^0.1.0:
1242312423
version "0.1.1"

0 commit comments

Comments
 (0)