[makeStyles] Fix jss StyleSheet attach() call

Ido Ben-Harosh · Ido Ben-Harosh · commit ca5583644006 · 2019-12-30T10:53:22.000+02:00
diff --git a/packages/material-ui-benchmark/src/styles.js b/packages/material-ui-benchmark/src/styles.js
@@ -128,7 +128,8 @@ suite
       const dynamicSheet = jss.createStyleSheet(dynamicStyles, {
         link: true,
       });
-      dynamicSheet.update({}).attach();
+      dynamicSheet.update({});
+      dynamicSheet.attach();
       sheetsRegistry.add(dynamicSheet);
     }
 
diff --git a/packages/material-ui-styles/src/makeStyles/makeStyles.js b/packages/material-ui-styles/src/makeStyles/makeStyles.js
@@ -109,7 +109,8 @@ function attach({ state, theme, stylesOptions, stylesCreator, name }, props) {
       ...options,
     });
 
-    dynamicSheet.update(props).attach();
+    dynamicSheet.update(props);
+    dynamicSheet.attach();
 
     state.dynamicSheet = dynamicSheet;
     state.classes = mergeClasses({

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,8 @@ suite`
`128`	`128`	`const dynamicSheet = jss.createStyleSheet(dynamicStyles, {`
`129`	`129`	`link: true,`
`130`	`130`	`});`
`131`		`- dynamicSheet.update({}).attach();`
	`131`	`+ dynamicSheet.update({});`
	`132`	`+ dynamicSheet.attach();`
`132`	`133`	`sheetsRegistry.add(dynamicSheet);`
`133`	`134`	`}`
`134`	`135`