[theme] Warn when palette structure is wrong #20253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
type: new feature
oliviertassinari
force-pushed
the
palette-improve-dx
branch
from
fe5a97f to
8c6d8f2
Compare
oliviertassinari
force-pushed
the
palette-improve-dx
branch
from
8c6d8f2 to
6792548
Compare
|
@material-ui/core: parsed: +0.17% , gzip: +0.25% Details of bundle changes.Comparing: d12a999...6b4f52c Details of page changes
|
eps1lon
reviewed
Mar 23, 2020
eps1lon
previously requested changes
Mar 23, 2020
Member
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
Well I have my usual reservations. console errors are just too easily missed. Defaulting to a different value when the input is wrong is not a good developer experience IMO. It's way more obvious to throw than log and use a default value.
Member
Author
|
@eps1lon Ideally I would 1. throw an explicit error in dev, and have a strange exception in production. But in the past, you have raised concerns about this approach. This leaves me us with two options: 2. the current one, 3. an explicit error in dev and prod but it has bundle size implication. What would you recommend? |
Member
That's fine. I'll check-out how to implement error codes for prod which should reduce the size implication to a minimum. Different error stack traces between dev and prod would make debugging a nightmare. |
Member
Author
In practice, I would imagine that the error in dev mode would prevent 99% of the cases to land in production. In the event to does land in production, I would imagine that the developer will try to reproduce the error locally, in which case he would see an error. Well, I get your point now. The developer would fix the error in dev but had no clue if he fixed the same one than in production, Eww. Ok, let's go with 3. I recall the error minification was done 4 years ago by an intern on the React team. Maybe we should estimate the potential win before looking into it? Which in any case, it should mean that we are clear to go. |
oliviertassinari
force-pushed
the
palette-improve-dx
branch
from
e218a9c to
6b4f52c
Compare
Member
Author
|
I have looked at how React handles the error encoding/decoding, it looks relatively simple: |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope that the following changes will resolve https://stackoverflow.com/questions/56897838/getting-a-error-typeerror-color-charat-is-not-a-function-in-c-node-modul (2k views in 8 months).
Closes #16341