-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[docs] Improve doc for textField and buttons #20207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Details of bundle changes.Comparing: a55c30b...7312a9d Details of page changes
|
| ### Cursor not-allowed | ||
|
|
||
| The ButtonBase component sets `pointer-events: none;` on disabled buttons, which prevents the appearance of a disabled cursor. | ||
| The `ButtonBase` component sets `pointer-events: none;` on disabled buttons, which prevents the appearance of a disabled cursor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that we didn't settle on a formating strategy for the components yet. There is a concern with the style of ``.
| The `ButtonBase` component sets `pointer-events: none;` on disabled buttons, which prevents the appearance of a disabled cursor. | |
| The ButtonBase component sets `pointer-events: none;` on disabled buttons, which prevents the appearance of a disabled cursor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @oliviertassinari not sure if i'm following you on this one. I noticed all the ButtonBase are decorated as code, and it felt like a bit inconsistency here. That's the reason behind this change. Let me if there's any concern or special case addressed for this one, i can revert it back :) Thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad you raise this consitency topic, I believe that if we take all the pages into account, it's highly inconsistent (50/50 usage split between these two forms). I wonder about what would be the best strategy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mbrookes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It used to be that the name of the UI pattern (e.g. 'expansion panel') was not formatted, but the name of the component ExpansionPanel was. I have no string preference whether it is or isn't formatted, once it's consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbrookes sounds great
Uh oh!
There was an error while loading. Please reload this page.