Skip to content

[Grid] Fix row-reverse typo #20048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

[Grid] Fix row-reverse typo #20048

merged 1 commit into from
Mar 10, 2020

Conversation

@jhthompson
Copy link
Contributor

@jhthompson jhthompson commented Mar 9, 2020

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 9, 2020

No bundle size changes comparing d47c518...1c2bd61

Generated by 🚫 dangerJS against 1c2bd61

@eps1lon eps1lon added the docs Improvements or additions to the documentation. label Mar 9, 2020
eps1lon
eps1lon approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Also: Our docs:api generator does not pick those up properly. Added it to the backlog.

ElianCodes
ElianCodes approved these changes Mar 9, 2020
View reviewed changes
Copy link

@ElianCodes ElianCodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is commented out, so noy very important, still; this typo should be fixed

@oliviertassinari oliviertassinari merged commit b4f4e2c into mui:master Mar 10, 2020
@oliviertassinari oliviertassinari added the component: Grid The React component. label Mar 10, 2020
This was referenced Mar 20, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
@jhthompson @EsoterikStare
[Grid] Fix row-reverse typo (mui#20048)
98bce82
This was referenced Apr 10, 2020
Closed
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

+1 more reviewer

@ElianCodes ElianCodes ElianCodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component: Grid The React component. docs Improvements or additions to the documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jhthompson @mui-pr-bot @eps1lon @ElianCodes @oliviertassinari