Skip to content

Conversation

@FottyM
Copy link
Contributor

@FottyM FottyM commented Feb 26, 2020

Someone mixed up the two country flags

Congo, DRC 🇨🇩

Congo, the Republic of 🇨🇬

@oliviertassinari oliviertassinari changed the title Update CountrySelect.js [Autocomplete] Fix list of counties Feb 26, 2020
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. labels Feb 26, 2020
{ code: 'CA', label: 'Canada', phone: '1', suggested: true },
{ code: 'CC', label: 'Cocos (Keeling) Islands', phone: '61' },
{ code: 'CD', label: 'Congo, Republic of the', phone: '242' },
{ code: 'CG', label: 'Congo, Republic of the', phone: '243' },
Copy link
Member

@oliviertassinari oliviertassinari Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? https://countrycode.org/congo

Suggested change
{ code: 'CG', label: 'Congo, Republic of the', phone: '243' },
{ code: 'CG', label: 'Congo, Republic of the', phone: '242' },

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 26, 2020

No bundle size changes comparing 9143f70...1eb3d6e

Generated by 🚫 dangerJS against 1eb3d6e

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the TypeScript version of the demo

@FottyM
Copy link
Contributor Author

FottyM commented Feb 26, 2020

We need to update the TypeScript version of the demo

The guideline doesn't say if I shouldn't ask stupid questions, so here we go.
I have never used yarn workspaces, so how do I go about it?
Should I just update typescript at the root of the entire project @oliviertassinari ?

@oliviertassinari
Copy link
Member

There is no stupid questions. You don't have to worry about yarn workspaces. As you as you run yarn on the root folder, you should be fine.

@FottyM
Copy link
Contributor Author

FottyM commented Feb 26, 2020

So it seems #19242 had already upgraded ts to the latest version. Or is there something I don't understand?
From what I see here is that all workspaces(subproject) utilize the same version of typescript.

@oliviertassinari
Copy link
Member

To clarify, each demo has a version in JavaScript and in TypeScript. You will get more details in the failed log of the CI, if it dare to complete (it still pending).

@joshwooding joshwooding changed the title [Autocomplete] Fix list of counties [Autocomplete] Fix list of countries Feb 26, 2020
@oliviertassinari
Copy link
Member

@FottyM Thanks for bringing this problem to light 💡!

@FottyM
Copy link
Contributor Author

FottyM commented Feb 27, 2020

sure no problem. I now understand that I needed to change the typescript version of the example as well, and not the version of ts itself 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: autocomplete Changes related to the autocomplete. This includes ComboBox.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants