Skip to content

[Autocomplete] Fix stuck with open popup #19794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 22, 2020
Merged

[Autocomplete] Fix stuck with open popup #19794

merged 6 commits into from
Feb 22, 2020

Conversation

@hasanozacar
Copy link
Contributor

@hasanozacar hasanozacar commented Feb 21, 2020 •
edited by oliviertassinari
Loading

Closes #19778

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 21, 2020 •
edited
Loading

Details of bundle changes.

Comparing: eec5b60...6ffdfed

bundle Size Change Size Gzip Change Gzip
useAutocomplete ▲ +153 B (+1.04% ) 14.8 kB ▲ +32 B (+0.60% ) 5.34 kB
@material-ui/lab ▲ +149 B (+0.08% ) 194 kB ▲ +81 B (+0.14% ) 57.3 kB
Autocomplete ▲ +149 B (+0.11% ) 132 kB ▲ +64 B (+0.15% ) 41.5 kB
OutlinedInput -- 75 kB ▼ -5 B (-0.02% ) 23.4 kB
Select -- 117 kB ▼ -3 B (-0.01% ) 34.7 kB
TextField -- 126 kB ▼ -3 B (-0.01% ) 36.7 kB
@material-ui/core -- 362 kB ▼ -2 B (-0.00% ) 99.1 kB
Backdrop -- 68.2 kB ▼ -2 B (-0.01% ) 21.1 kB
Modal -- 14.5 kB ▲ +2 B (+0.04% ) 5.04 kB
Snackbar -- 75.7 kB ▲ +2 B (+0.01% ) 23.7 kB
Zoom -- 23.6 kB ▼ -2 B (-0.02% ) 8.12 kB
ClickAwayListener -- 3.91 kB ▲ +1 B (+0.06% ) 1.55 kB
Drawer -- 85.2 kB ▼ -1 B (-0.00% ) 25.9 kB
ExpansionPanel -- 72.7 kB ▼ -1 B (-0.00% ) 22.7 kB
Fade -- 23.6 kB ▲ +1 B (+0.01% ) 8.01 kB
Grow -- 24.2 kB ▲ +1 B (+0.01% ) 8.22 kB
Hidden -- 66.3 kB ▼ -1 B (-0.00% ) 20.8 kB
Menu -- 89.1 kB ▼ -1 B (-0.00% ) 27.4 kB
MenuList -- 66.4 kB ▼ -1 B (-0.00% ) 20.8 kB
Popover -- 83.5 kB ▲ +1 B (0.00% ) 25.8 kB
Slide -- 25.7 kB ▼ -1 B (-0.01% ) 8.74 kB
SpeedDialAction -- 119 kB ▼ -1 B (-0.00% ) 37.6 kB
StepContent -- 69.5 kB ▼ -1 B (-0.00% ) 21.8 kB
SwipeableDrawer -- 92.6 kB ▼ -1 B (-0.00% ) 28.9 kB
TablePagination -- 144 kB ▲ +1 B (0.00% ) 42 kB
@material-ui/core[umd] -- 318 kB -- 92.2 kB
@material-ui/styles -- 51.4 kB -- 15.4 kB
@material-ui/system -- 16.5 kB -- 4.32 kB
Alert -- 83.8 kB -- 26.3 kB
AlertTitle -- 64.5 kB -- 20.3 kB
AppBar -- 64.4 kB -- 20.2 kB
Avatar -- 65.6 kB -- 20.7 kB
AvatarGroup -- 62.7 kB -- 19.7 kB
Badge -- 65.7 kB -- 20.4 kB
BottomNavigation -- 62.7 kB -- 19.7 kB
BottomNavigationAction -- 75.9 kB -- 24 kB
Box -- 72.2 kB -- 21.9 kB
Breadcrumbs -- 80.8 kB -- 25.4 kB
Button -- 80.1 kB -- 24.5 kB
ButtonBase -- 74.4 kB -- 23.3 kB
ButtonGroup -- 83.6 kB -- 25.6 kB
Card -- 63.2 kB -- 19.8 kB
CardActionArea -- 75.5 kB -- 23.8 kB
CardActions -- 62.4 kB -- 19.6 kB
CardContent -- 62.3 kB -- 19.5 kB
CardHeader -- 65.4 kB -- 20.6 kB
CardMedia -- 62.7 kB -- 19.7 kB
Checkbox -- 83.4 kB -- 26.3 kB
Chip -- 83 kB -- 25.4 kB
CircularProgress -- 64.4 kB -- 20.3 kB
Collapse -- 68.4 kB -- 21.2 kB
colorManipulator -- 3.88 kB -- 1.52 kB
Container -- 63.5 kB -- 19.9 kB
CssBaseline -- 62.3 kB -- 19.6 kB
Dialog -- 83.4 kB -- 26 kB
DialogActions -- 62.4 kB -- 19.6 kB
DialogContent -- 62.6 kB -- 19.6 kB
DialogContentText -- 64.4 kB -- 20.2 kB
DialogTitle -- 64.6 kB -- 20.3 kB
Divider -- 63 kB -- 19.8 kB
docs.landing -- 56.8 kB -- 15.6 kB
docs.main -- 604 kB -- 196 kB
ExpansionPanelActions -- 62.4 kB -- 19.6 kB
ExpansionPanelDetails -- 62.3 kB -- 19.5 kB
ExpansionPanelSummary -- 78.5 kB -- 24.8 kB
Fab -- 77.2 kB -- 24.1 kB
FilledInput -- 74 kB -- 23 kB
FormControl -- 64.8 kB -- 20.2 kB
FormControlLabel -- 65.9 kB -- 20.6 kB
FormGroup -- 62.3 kB -- 19.6 kB
FormHelperText -- 63.7 kB -- 20 kB
FormLabel -- 63.8 kB -- 19.8 kB
Grid -- 65.4 kB -- 20.5 kB
GridList -- 62.8 kB -- 19.7 kB
GridListTile -- 64.1 kB -- 20.1 kB
GridListTileBar -- 63.6 kB -- 19.9 kB
Icon -- 63.1 kB -- 19.8 kB
IconButton -- 76.6 kB -- 23.9 kB
Input -- 73 kB -- 22.8 kB
InputAdornment -- 65.4 kB -- 20.6 kB
InputBase -- 71.1 kB -- 22.3 kB
InputLabel -- 65.7 kB -- 20.5 kB
LinearProgress -- 65.7 kB -- 20.5 kB
Link -- 67 kB -- 21.1 kB
List -- 62.7 kB -- 19.6 kB
ListItem -- 77.6 kB -- 24.2 kB
ListItemAvatar -- 62.5 kB -- 19.5 kB
ListItemIcon -- 62.5 kB -- 19.6 kB
ListItemSecondaryAction -- 62.3 kB -- 19.5 kB
ListItemText -- 65.3 kB -- 20.5 kB
ListSubheader -- 63.1 kB -- 19.8 kB
MenuItem -- 78.6 kB -- 24.5 kB
MobileStepper -- 68.2 kB -- 21.4 kB
NativeSelect -- 77.3 kB -- 24.4 kB
NoSsr -- 2.19 kB -- 1.04 kB
Pagination -- 85.6 kB -- 26.3 kB
PaginationItem -- 81.2 kB -- 25 kB
Paper -- 62.7 kB -- 19.6 kB
Popper -- 28.8 kB -- 10.3 kB
Portal -- 2.92 kB -- 1.3 kB
Radio -- 84.4 kB -- 26.6 kB
RadioGroup -- 64.8 kB -- 20.1 kB
Rating -- 70.8 kB -- 22.8 kB
RootRef -- 4.24 kB -- 1.64 kB
ScopedCssBaseline -- 63.2 kB -- 19.9 kB
Skeleton -- 63.3 kB -- 20 kB
Slider -- 77 kB -- 24.2 kB
SnackbarContent -- 63.9 kB -- 20.1 kB
SpeedDial -- 86.7 kB -- 27.3 kB
SpeedDialIcon -- 64.9 kB -- 20.3 kB
Step -- 63 kB -- 19.8 kB
StepButton -- 82.8 kB -- 26.2 kB
StepConnector -- 63.1 kB -- 19.9 kB
StepIcon -- 65 kB -- 20.3 kB
StepLabel -- 69 kB -- 21.7 kB
Stepper -- 65.2 kB -- 20.6 kB
styles/createMuiTheme -- 16.6 kB -- 5.85 kB
SvgIcon -- 63.4 kB -- 19.8 kB
Switch -- 82.6 kB -- 26 kB
Tab -- 76.7 kB -- 24.3 kB
Table -- 62.9 kB -- 19.7 kB
TableBody -- 62.4 kB -- 19.5 kB
TableCell -- 64.4 kB -- 20.3 kB
TableContainer -- 62.3 kB -- 19.5 kB
TableFooter -- 62.5 kB -- 19.5 kB
TableHead -- 62.4 kB -- 19.5 kB
TableRow -- 62.8 kB -- 19.7 kB
TableSortLabel -- 77.8 kB -- 24.4 kB
Tabs -- 85.8 kB -- 27.2 kB
TextareaAutosize -- 5.24 kB -- 2.18 kB
ToggleButton -- 76.6 kB -- 24.2 kB
ToggleButtonGroup -- 63.5 kB -- 20 kB
Toolbar -- 62.7 kB -- 19.7 kB
Tooltip -- 103 kB -- 32.4 kB
TreeItem -- 74.3 kB -- 23.5 kB
TreeView -- 67 kB -- 21.1 kB
Typography -- 64 kB -- 20 kB
useMediaQuery -- 2.58 kB -- 1.06 kB

Generated by 🚫 dangerJS against 6ffdfed

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. labels Feb 21, 2020
@oliviertassinari oliviertassinari changed the title Fix issues #19778 [Autocomplete] Fix stuck with open popup Feb 21, 2020
@oliviertassinari oliviertassinari self-assigned this Feb 21, 2020
@eps1lon eps1lon added the PR: needs test The pull request needs tests. label Feb 21, 2020
@oliviertassinari oliviertassinari added PR: ready to ship and removed PR: needs test The pull request needs tests. labels Feb 22, 2020
@oliviertassinari oliviertassinari merged commit deb31c7 into mui:master Feb 22, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 22, 2020

@hasanozacar Thanks for exploring the problem

@bryceosterhaus bryceosterhaus mentioned this pull request Feb 24, 2020
Closed
@hasanozacar
Copy link
Contributor Author

hasanozacar commented Mar 2, 2020

@oliviertassinari 44/5000
Thank you for completing the pr

This was referenced Mar 10, 2020
Merged
Closed
Open
This was referenced Mar 21, 2020
Merged
Open
Closed
EsoterikStare pushed a commit to EsoterikStare/material-ui that referenced this pull request Mar 30, 2020
@hasanozacar @EsoterikStare
[Autocomplete] Fix stuck with open popup (mui#19794)
0a9cd37
This was referenced Apr 16, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

@oliviertassinari oliviertassinari

Labels

scope: autocomplete Changes related to the autocomplete. This includes ComboBox. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Autocomplete] Drop list no close outline mouse

4 participants

@hasanozacar @mui-pr-bot @oliviertassinari @eps1lon