Skip to content

[core] Batch small changes #19717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 15, 2020
Merged

[core] Batch small changes #19717

merged 6 commits into from
Feb 15, 2020

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Feb 15, 2020

  • [docs] There are 1,100 icons now 3df2bee: Google has been busy.
  • [backers] Let's try a lower Diamond point 3d6d94f: Maybe it will better resonate.
  • [job] Not knowing Material-UI can also be an advantage 532d638: Onboarding somebody that has a lot of experience with another UI framework could be as valuable as somebody that knows Material-UI strength and weaknesses => a new perspective.
  • [Divider] Update flexItem description 56de4de: comment by @mbrookes.
  • [docs] Clarify diff between select and autocomplete 40448de: I have seen this confusion come up multiple times
  • [Portal] typeof Element doesn't work in iframe 639de37: Opened instanceOf(Element) doesn't work in iframe merceyz/typescript-to-proptypes#3.

@oliviertassinari oliviertassinari added the umbrella For grouping multiple issues to provide a holistic view label Feb 15, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Feb 15, 2020

No bundle size changes comparing c1c6690...2ecbea4

Generated by 🚫 dangerJS against 2ecbea4

@oliviertassinari oliviertassinari merged commit 0426817 into mui:master Feb 15, 2020
@oliviertassinari oliviertassinari deleted the batch-small-changes-v24 branch February 15, 2020 16:41
This was referenced Mar 10, 2020
Merged
Merged
Merged
Closed
Closed
Closed
Open
This was referenced Mar 21, 2020
Merged
Open
This was referenced Apr 16, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbrookes mbrookes mbrookes approved these changes

Assignees

No one assigned

Labels

umbrella For grouping multiple issues to provide a holistic view

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oliviertassinari @mui-pr-bot @mbrookes