test: Exclude inaccessible elements by default in browser tests #19380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 0177cd6...47ae807 |
Member
Author
|
Now logs |
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Feb 13, 2020
This was referenced Mar 10, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser tests are bundled with webpack. They don't have access to environment variables unless we explicitly inject them with a webpack plugin.
CI is supposed to exclude inaccessible elements by default which was not the case. See e.g. https://app.circleci.com/jobs/github/mui-org/material-ui/136811 where it logs "WARN: 'including inaccessible elements by default'"