[theme] Support breakpoints.between(a, b) with number #19003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 5533914...e2138cb
|
oliviertassinari
added
the
type: new feature
|
@ulises-lara Great start. Could you add a new test case? Thanks |
Sure thing, I will be working on that! |
oliviertassinari
changed the title
oliviertassinari
approved these changes
Dec 31, 2019
|
@ulises-lara Thanks |
|
Should probably update the types for this as well |
oliviertassinari
added a commit
to oliviertassinari/material-ui
that referenced
this pull request
Jan 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements changes to the src/styles/createBreakpoints.js file.
It aims to implement support for arbitrary/custom breakpoint values, for consistency purposes, as discussed in the following issue:
Closes #18652