[TableSortLabel] Relax IconComponent requirements in TypeScript #18936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2019 14:46
- IconComponent only requires to accept className prop
|
No bundle size changes comparing 0b2196c...debe9ad |
Member
|
@Igorbek Thanks! |
oliviertassinari
changed the title
This was referenced Feb 23, 2020
vkentta
pushed a commit
to vkentta/material-ui
that referenced
this pull request
Nov 5, 2020
Related previous PR: mui#18936 Currently passing an element typed as `React.ComponentType<SvgIconProps>` (as IconComponent was originally typed) gives an error, as `className` is not required in `SvgIconProps`.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the source
TableSortLabelonly passesclassNameto theIconComponent: https://github.com/mui-org/material-ui/blob/master/packages/material-ui/src/TableSortLabel/TableSortLabel.js#L82-L84So this PR relaxes the requirement to
IconComponentprop in TypeScript.