Skip to content

[RadioGroup] Add useRadioGroup Hook #18920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 27, 2019
Merged

[RadioGroup] Add useRadioGroup Hook #18920

merged 2 commits into from
Dec 27, 2019

Conversation

@NMinhNguyen
Copy link
Contributor

@NMinhNguyen NMinhNguyen commented Dec 19, 2019

Closes #18918

NMinhNguyen
NMinhNguyen commented Dec 19, 2019
View reviewed changes
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 19, 2019 •
edited
Loading

@material-ui/core: parsed: +0.10% , gzip: +0.07%

Details of bundle changes.

Comparing: 3afb41f...83a205e

bundle Size Change Size Gzip Change Gzip
@material-ui/core ▲ +343 B (+0.10% ) 358 kB ▲ +67 B (+0.07% ) 97.7 kB
RadioGroup ▲ +195 B (+0.31% ) 63.1 kB ▲ +86 B (+0.44% ) 19.8 kB
Radio ▲ +130 B (+0.16% ) 82.7 kB ▲ +18 B (+0.07% ) 26.1 kB
@material-ui/core[umd] ▲ +49 B (+0.02% ) 314 kB ▲ +17 B (+0.02% ) 90.6 kB
Autocomplete ▲ +3 B (0.00% ) 129 kB ▲ +1 B (0.00% ) 40.4 kB
Drawer ▲ +3 B (0.00% ) 84.2 kB ▼ -1 B (-0.00% ) 25.7 kB
Chip ▲ +3 B (0.00% ) 82.2 kB -- 25.2 kB
Menu ▲ +3 B (0.00% ) 88.1 kB -- 27.2 kB
MenuItem ▲ +3 B (0.00% ) 77.8 kB -- 24.4 kB
@material-ui/lab ▲ +1 B (0.00% ) 176 kB ▼ -3 B (-0.01% ) 53.1 kB
FormLabel ▲ +1 B (0.00% ) 63.2 kB ▲ +1 B (+0.01% ) 19.6 kB
InputLabel ▲ +1 B (0.00% ) 65 kB ▲ +1 B (0.00% ) 20.1 kB
StepIcon ▲ +1 B (0.00% ) 64.3 kB ▲ +1 B (0.00% ) 20.1 kB
StepLabel ▲ +1 B (0.00% ) 68.3 kB ▲ +1 B (0.00% ) 21.2 kB
TablePagination ▲ +1 B (0.00% ) 141 kB ▼ -1 B (-0.00% ) 41.3 kB
Tooltip ▲ +1 B (0.00% ) 101 kB ▲ +1 B (0.00% ) 31.9 kB
Backdrop ▲ +1 B (0.00% ) 67.4 kB -- 20.9 kB
Button ▲ +1 B (0.00% ) 79.4 kB -- 24.4 kB
Collapse ▲ +1 B (0.00% ) 67.6 kB -- 21 kB
Fab ▲ +1 B (0.00% ) 76.5 kB -- 23.9 kB
Fade ▲ +1 B (0.00% ) 23.2 kB -- 7.98 kB
FilledInput ▲ +1 B (0.00% ) 73.2 kB -- 22.8 kB
FormControl ▲ +1 B (0.00% ) 64.1 kB -- 20 kB
List ▲ +1 B (0.00% ) 62 kB -- 19.4 kB
ListItem ▲ +1 B (0.00% ) 76.8 kB -- 24.1 kB
MenuList ▲ +1 B (0.00% ) 65.7 kB -- 20.6 kB
OutlinedInput ▲ +1 B (0.00% ) 73.7 kB -- 23 kB
Popover ▲ +1 B (0.00% ) 82.5 kB -- 25.6 kB
Select ▲ +1 B (0.00% ) 114 kB -- 34 kB
TextField ▲ +1 B (0.00% ) 123 kB -- 36.1 kB
Link -- 66.3 kB ▼ -51 B (-0.24% ) 21 kB
ButtonGroup -- 82.8 kB ▲ +6 B (+0.02% ) 25.5 kB
ExpansionPanel -- 71.1 kB ▼ -6 B (-0.03% ) 22.3 kB
Stepper -- 64.6 kB ▲ +5 B (+0.02% ) 20.4 kB
ToggleButton -- 75.8 kB ▲ +4 B (+0.02% ) 24.1 kB
@material-ui/system -- 14.5 kB ▼ -3 B (-0.07% ) 4.04 kB
AppBar -- 63.6 kB ▼ -3 B (-0.01% ) 20 kB
Box -- 70.4 kB ▲ +3 B (+0.01% ) 21.5 kB
Card -- 62.5 kB ▲ +3 B (+0.02% ) 19.6 kB
CardActionArea -- 74.7 kB ▼ -3 B (-0.01% ) 23.6 kB
Hidden -- 65.6 kB ▼ -3 B (-0.01% ) 20.7 kB
SpeedDial -- 85.7 kB ▼ -3 B (-0.01% ) 27.1 kB
BottomNavigationAction -- 75.2 kB ▼ -2 B (-0.01% ) 23.8 kB
CardMedia -- 62 kB ▼ -2 B (-0.01% ) 19.6 kB
CircularProgress -- 63.8 kB ▲ +2 B (+0.01% ) 20.2 kB
CssBaseline -- 57.3 kB ▼ -2 B (-0.01% ) 18 kB
ExpansionPanelDetails -- 61.6 kB ▲ +2 B (+0.01% ) 19.4 kB
FormControlLabel -- 65.2 kB ▲ +2 B (+0.01% ) 20.5 kB
FormHelperText -- 63 kB ▲ +2 B (+0.01% ) 19.8 kB
Grid -- 64.8 kB ▲ +2 B (+0.01% ) 20.4 kB
InputAdornment -- 64.8 kB ▲ +2 B (+0.01% ) 20.4 kB
Rating -- 69.7 kB ▲ +2 B (+0.01% ) 22.5 kB
StepButton -- 82 kB ▲ +2 B (+0.01% ) 26 kB
TableBody -- 61.8 kB ▲ +2 B (+0.01% ) 19.4 kB
ToggleButtonGroup -- 62.9 kB ▼ -2 B (-0.01% ) 19.8 kB
TreeItem -- 73.4 kB ▲ +2 B (+0.01% ) 23.3 kB
useMediaQuery -- 2.5 kB ▲ +2 B (+0.19% ) 1.06 kB
@material-ui/styles -- 50.8 kB ▲ +1 B (+0.01% ) 15.3 kB
Avatar -- 64.9 kB ▼ -1 B (-0.00% ) 20.5 kB
AvatarGroup -- 62 kB ▲ +1 B (+0.01% ) 19.5 kB
BottomNavigation -- 62.1 kB ▲ +1 B (+0.01% ) 19.5 kB
Breadcrumbs -- 67.7 kB ▲ +1 B (0.00% ) 21.3 kB
CardActions -- 61.7 kB ▼ -1 B (-0.01% ) 19.4 kB
CardContent -- 61.7 kB ▼ -1 B (-0.01% ) 19.4 kB
Container -- 62.9 kB ▲ +1 B (+0.01% ) 19.7 kB
Dialog -- 82.4 kB ▲ +1 B (0.00% ) 25.8 kB
DialogActions -- 61.8 kB ▲ +1 B (+0.01% ) 19.4 kB
DialogContent -- 61.9 kB ▼ -1 B (-0.01% ) 19.5 kB
DialogTitle -- 64 kB ▲ +1 B (0.00% ) 20.1 kB
Divider -- 62.3 kB ▼ -1 B (-0.01% ) 19.6 kB
ExpansionPanelActions -- 61.8 kB ▲ +1 B (+0.01% ) 19.4 kB
ExpansionPanelSummary -- 77.8 kB ▲ +1 B (0.00% ) 24.6 kB
FormGroup -- 61.7 kB ▼ -1 B (-0.01% ) 19.4 kB
GridList -- 62.2 kB ▲ +1 B (+0.01% ) 19.6 kB
GridListTile -- 63.4 kB ▼ -1 B (-0.01% ) 19.9 kB
GridListTileBar -- 62.9 kB ▼ -1 B (-0.01% ) 19.8 kB
ListItemIcon -- 61.9 kB ▲ +1 B (+0.01% ) 19.4 kB
ListItemSecondaryAction -- 61.7 kB ▲ +1 B (+0.01% ) 19.4 kB
ListSubheader -- 62.4 kB ▲ +1 B (+0.01% ) 19.7 kB
MobileStepper -- 67.5 kB ▲ +1 B (0.00% ) 21.2 kB
RootRef -- 4.21 kB ▲ +1 B (+0.06% ) 1.64 kB
Slide -- 25.3 kB ▼ -1 B (-0.01% ) 8.71 kB
Slider -- 75.3 kB ▲ +1 B (0.00% ) 23.9 kB
Snackbar -- 74.8 kB ▲ +1 B (0.00% ) 23.4 kB
SnackbarContent -- 63.2 kB ▲ +1 B (+0.01% ) 20 kB
SpeedDialIcon -- 64.3 kB ▲ +1 B (0.00% ) 20.2 kB
StepConnector -- 62.4 kB ▲ +1 B (+0.01% ) 19.7 kB
StepContent -- 68.7 kB ▼ -1 B (-0.00% ) 21.6 kB
Switch -- 80.8 kB ▲ +1 B (0.00% ) 25.5 kB
Tab -- 76 kB ▼ -1 B (-0.00% ) 24.1 kB
Table -- 62.2 kB ▼ -1 B (-0.01% ) 19.6 kB
TableContainer -- 61.7 kB ▼ -1 B (-0.01% ) 19.4 kB
TableFooter -- 61.8 kB ▼ -1 B (-0.01% ) 19.4 kB
TableHead -- 61.8 kB ▲ +1 B (+0.01% ) 19.4 kB
TableRow -- 62.2 kB ▲ +1 B (+0.01% ) 19.6 kB
TableSortLabel -- 77 kB ▲ +1 B (0.00% ) 24.3 kB
Tabs -- 85.1 kB ▼ -1 B (-0.00% ) 27.1 kB
Toolbar -- 62 kB ▲ +1 B (+0.01% ) 19.6 kB
TreeView -- 66.1 kB ▲ +1 B (0.00% ) 20.8 kB
Zoom -- 23.3 kB ▼ -1 B (-0.01% ) 8.1 kB
Badge -- 65 kB -- 20.3 kB
ButtonBase -- 73.6 kB -- 23.2 kB
CardHeader -- 64.8 kB -- 20.4 kB
Checkbox -- 81.6 kB -- 25.9 kB
ClickAwayListener -- 3.85 kB -- 1.55 kB
colorManipulator -- 3.85 kB -- 1.52 kB
DialogContentText -- 63.7 kB -- 20.1 kB
docs.landing -- 50.7 kB -- 13.4 kB
docs.main -- 613 kB -- 196 kB
Grow -- 23.8 kB -- 8.19 kB
Icon -- 62.5 kB -- 19.6 kB
IconButton -- 75.8 kB -- 23.7 kB
Input -- 72.2 kB -- 22.6 kB
InputBase -- 70.3 kB -- 22.1 kB
LinearProgress -- 65 kB -- 20.4 kB
ListItemAvatar -- 61.8 kB -- 19.4 kB
ListItemText -- 64.6 kB -- 20.4 kB
Modal -- 14.3 kB -- 5.01 kB
NativeSelect -- 76.5 kB -- 24.2 kB
NoSsr -- 2.19 kB -- 1.04 kB
Paper -- 62 kB -- 19.4 kB
Popper -- 28.7 kB -- 10.3 kB
Portal -- 2.9 kB -- 1.3 kB
Skeleton -- 62.3 kB -- 19.7 kB
SpeedDialAction -- 117 kB -- 37 kB
Step -- 62.3 kB -- 19.6 kB
styles/createMuiTheme -- 16.4 kB -- 5.83 kB
SvgIcon -- 62.7 kB -- 19.6 kB
SwipeableDrawer -- 91.6 kB -- 28.7 kB
TableCell -- 63.7 kB -- 20.1 kB
TextareaAutosize -- 5.09 kB -- 2.14 kB
Typography -- 63.3 kB -- 19.9 kB
useAutocomplete -- 12.6 kB -- 4.7 kB

Generated by 🚫 dangerJS against 83a205e

@eps1lon eps1lon added component: RadioGroup type: new feature Expand the scope of the product to solve a new problem. labels Dec 27, 2019
@eps1lon eps1lon merged commit 219876b into mui:master Dec 27, 2019
@eps1lon
Copy link
Member

eps1lon commented Dec 27, 2019

@NMinhNguyen Much appreciated, thanks!

@NMinhNguyen NMinhNguyen mentioned this pull request Dec 27, 2019
Merged
1 task
@NMinhNguyen NMinhNguyen deleted the feat/useRadioGroup branch December 27, 2019 17:27
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
This was referenced Feb 23, 2020
Open
Closed
@oliviertassinari oliviertassinari added scope: radio Changes related to the radio. and removed component: RadioGroup labels Mar 31, 2020
@snyk-bot snyk-bot mentioned this pull request Apr 6, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon left review comments

Assignees

No one assigned

Labels

scope: radio Changes related to the radio. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose RadioGroupContext via useRadioGroup Hook

4 participants

@NMinhNguyen @mui-pr-bot @eps1lon @oliviertassinari