Skip to content

[Tooltip] Fix onMouseOver event leak #18687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2019
Merged

[Tooltip] Fix onMouseOver event leak #18687

merged 3 commits into from
Dec 5, 2019

Conversation

@r3dm1ke
Copy link
Contributor

@r3dm1ke r3dm1ke commented Dec 4, 2019

Fixes #18679

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 4, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 1073d82...ddf53d8

bundle Size Change Size Gzip Change Gzip
SpeedDialAction ▲ +84 B (+0.07% ) 116 kB ▲ +12 B (+0.03% ) 36.5 kB
@material-ui/core ▲ +84 B (+0.02% ) 354 kB ▲ +11 B (+0.01% ) 96.7 kB
@material-ui/lab ▲ +84 B (+0.05% ) 174 kB ▲ +11 B (+0.02% ) 52.2 kB
@material-ui/core[umd] ▲ +84 B (+0.03% ) 311 kB ▲ +10 B (+0.01% ) 89.6 kB
docs.main ▲ +84 B (+0.01% ) 609 kB ▲ +10 B (+0.01% ) 194 kB
Tooltip ▲ +84 B (+0.08% ) 99.5 kB ▲ +10 B (+0.03% ) 31.4 kB
@material-ui/styles -- 51 kB -- 15.3 kB
@material-ui/system -- 14.8 kB -- 4.06 kB
AppBar -- 62.7 kB -- 19.5 kB
Autocomplete -- 127 kB -- 39.7 kB
Avatar -- 61.7 kB -- 19.3 kB
Backdrop -- 66.6 kB -- 20.5 kB
Badge -- 64.2 kB -- 19.9 kB
BottomNavigation -- 61.3 kB -- 19.1 kB
BottomNavigationAction -- 74.3 kB -- 23.4 kB
Box -- 69.6 kB -- 21 kB
Breadcrumbs -- 66.9 kB -- 20.8 kB
Button -- 78.3 kB -- 23.9 kB
ButtonBase -- 72.8 kB -- 22.7 kB
ButtonGroup -- 80.9 kB -- 24.8 kB
Card -- 61.6 kB -- 19.2 kB
CardActionArea -- 73.9 kB -- 23.2 kB
CardActions -- 60.9 kB -- 19 kB
CardContent -- 60.9 kB -- 19 kB
CardHeader -- 64 kB -- 20 kB
CardMedia -- 61.2 kB -- 19.2 kB
Checkbox -- 80.6 kB -- 25.3 kB
Chip -- 81.4 kB -- 24.8 kB
CircularProgress -- 63 kB -- 19.8 kB
ClickAwayListener -- 3.87 kB -- 1.56 kB
Collapse -- 66.8 kB -- 20.6 kB
colorManipulator -- 3.85 kB -- 1.52 kB
Container -- 62 kB -- 19.3 kB
CssBaseline -- 56.4 kB -- 17.6 kB
Dialog -- 81.5 kB -- 25.4 kB
DialogActions -- 61 kB -- 19 kB
DialogContent -- 61.1 kB -- 19.1 kB
DialogContentText -- 62.9 kB -- 19.7 kB
DialogTitle -- 63.2 kB -- 19.7 kB
Divider -- 61.5 kB -- 19.2 kB
docs.landing -- 52.4 kB -- 11.4 kB
Drawer -- 83.2 kB -- 25.2 kB
ExpansionPanel -- 70.1 kB -- 21.8 kB
ExpansionPanelActions -- 61 kB -- 19 kB
ExpansionPanelDetails -- 60.8 kB -- 19 kB
ExpansionPanelSummary -- 76.9 kB -- 24.2 kB
Fab -- 75.6 kB -- 23.5 kB
Fade -- 22.4 kB -- 7.71 kB
FilledInput -- 72.3 kB -- 22.4 kB
FormControl -- 63.3 kB -- 19.6 kB
FormControlLabel -- 64.4 kB -- 20.1 kB
FormGroup -- 60.9 kB -- 19 kB
FormHelperText -- 62.1 kB -- 19.4 kB
FormLabel -- 62.4 kB -- 19.2 kB
Grid -- 64 kB -- 20 kB
GridList -- 61.4 kB -- 19.2 kB
GridListTile -- 62.6 kB -- 19.5 kB
GridListTileBar -- 62.1 kB -- 19.3 kB
Grow -- 23.1 kB -- 7.83 kB
Hidden -- 64.8 kB -- 20.2 kB
Icon -- 61.7 kB -- 19.2 kB
IconButton -- 75 kB -- 23.3 kB
Input -- 71.3 kB -- 22.1 kB
InputAdornment -- 64 kB -- 20 kB
InputBase -- 69.4 kB -- 21.7 kB
InputLabel -- 64.2 kB -- 20 kB
LinearProgress -- 64.2 kB -- 20 kB
Link -- 65.5 kB -- 20.6 kB
List -- 61.3 kB -- 19 kB
ListItem -- 75.9 kB -- 23.6 kB
ListItemAvatar -- 61 kB -- 19 kB
ListItemIcon -- 61.1 kB -- 19 kB
ListItemSecondaryAction -- 60.9 kB -- 19 kB
ListItemText -- 63.8 kB -- 19.9 kB
ListSubheader -- 61.6 kB -- 19.3 kB
Menu -- 87.1 kB -- 26.8 kB
MenuItem -- 77 kB -- 23.9 kB
MenuList -- 64.9 kB -- 20.2 kB
MobileStepper -- 66.6 kB -- 20.8 kB
Modal -- 14.2 kB -- 4.99 kB
NativeSelect -- 75.6 kB -- 23.7 kB
NoSsr -- 2.19 kB -- 1.03 kB
OutlinedInput -- 72.8 kB -- 22.6 kB
Paper -- 61.1 kB -- 19 kB
Popover -- 81.5 kB -- 25.1 kB
Popper -- 28.6 kB -- 10.2 kB
Portal -- 2.87 kB -- 1.29 kB
Radio -- 81.5 kB -- 25.6 kB
RadioGroup -- 62.1 kB -- 19.4 kB
Rating -- 68.9 kB -- 22.1 kB
RootRef -- 4.43 kB -- 1.67 kB
Select -- 113 kB -- 33.5 kB
Skeleton -- 61.4 kB -- 19.3 kB
Slide -- 24.5 kB -- 8.32 kB
Slider -- 74.5 kB -- 23.3 kB
Snackbar -- 76 kB -- 23.7 kB
SnackbarContent -- 64.5 kB -- 20.2 kB
SpeedDial -- 84.9 kB -- 26.7 kB
SpeedDialIcon -- 63.5 kB -- 19.9 kB
Step -- 61.5 kB -- 19.2 kB
StepButton -- 81.1 kB -- 25.5 kB
StepConnector -- 61.6 kB -- 19.3 kB
StepContent -- 67.9 kB -- 21.2 kB
StepIcon -- 63.5 kB -- 19.7 kB
StepLabel -- 67.5 kB -- 21.1 kB
Stepper -- 63.6 kB -- 20 kB
styles/createMuiTheme -- 15.6 kB -- 5.47 kB
SvgIcon -- 61.9 kB -- 19.3 kB
SwipeableDrawer -- 90.6 kB -- 28 kB
Switch -- 80 kB -- 25 kB
Tab -- 75.2 kB -- 23.7 kB
Table -- 61.4 kB -- 19.2 kB
TableBody -- 61 kB -- 19 kB
TableCell -- 62.9 kB -- 19.7 kB
TableFooter -- 61 kB -- 19 kB
TableHead -- 61 kB -- 19 kB
TablePagination -- 140 kB -- 40.7 kB
TableRow -- 61.4 kB -- 19.1 kB
TableSortLabel -- 76.2 kB -- 23.9 kB
Tabs -- 84.3 kB -- 26.5 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
TextField -- 122 kB -- 35.5 kB
ToggleButton -- 75 kB -- 23.7 kB
ToggleButtonGroup -- 62.1 kB -- 19.4 kB
Toolbar -- 61.2 kB -- 19.1 kB
TreeItem -- 72.5 kB -- 22.8 kB
TreeView -- 65.3 kB -- 20.4 kB
Typography -- 62.5 kB -- 19.5 kB
useAutocomplete -- 12.4 kB -- 4.56 kB
useMediaQuery -- 2.47 kB -- 1.04 kB
Zoom -- 22.5 kB -- 7.71 kB

Generated by 🚫 dangerJS against ddf53d8

@oliviertassinari oliviertassinari changed the title [Tooltip] Fixing inconsistent behaviour of tooltip on hover [Tooltip] Fix onMouseOver event leak Dec 4, 2019
@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. scope: tooltip Changes related to the tooltip. labels Dec 4, 2019
@oliviertassinari oliviertassinari force-pushed the 18679-inconsistent-tooltip-behaviour branch from e3a157e to 5160354 Compare December 4, 2019 23:45
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 4, 2019

@r3dm1ke Thanks, I have tried to push this effort a bit further. I think that it's good enough to land :).

@oliviertassinari oliviertassinari force-pushed the 18679-inconsistent-tooltip-behaviour branch from 5160354 to ddf53d8 Compare December 4, 2019 23:58
@oliviertassinari oliviertassinari merged commit c98b9c4 into mui:master Dec 5, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 5, 2019

Thank you

eps1lon
eps1lon reviewed Dec 5, 2019
View reviewed changes
packages/material-ui/src/Tooltip/Tooltip.test.js
</Tooltip>,
);
fireEvent.mouseOver(getByRole('tooltip'));
expect(handleMouseOver.callCount).to.equal(0);
Copy link
Member

@eps1lon eps1lon Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a nice test case, thanks!

@r3dm1ke r3dm1ke deleted the 18679-inconsistent-tooltip-behaviour branch December 11, 2019 19:07
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
@eps1lon eps1lon mentioned this pull request Feb 28, 2020
Closed
2 tasks
@eps1lon
Copy link
Member

eps1lon commented Oct 5, 2020

Note: This didn't fix the underlying issue. We should've checked the codesandbox: https://codesandbox.io/s/dazzling-rain-7vx5l. The Tooltip is no longer hoverable in that demo.

screen recording of trying to hover the Tooltip on this branch

@eps1lon eps1lon mentioned this pull request Oct 5, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon left review comments

Assignees

No one assigned

Labels

scope: tooltip Changes related to the tooltip. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Slider] Interactive tooltips on range slider has inconsistent behavior

4 participants

@r3dm1ke @mui-pr-bot @oliviertassinari @eps1lon