Skip to content

[Typography] Adapt lineHeight for h1-h5 #18663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2019
Merged

[Typography] Adapt lineHeight for h1-h5 #18663

merged 2 commits into from
Dec 7, 2019

Conversation

@LorenzHenk
Copy link

@LorenzHenk LorenzHenk commented Dec 3, 2019

Closes #18659 using this proposed diff.

@oliviertassinari oliviertassinari added the scope: typography Changes related to typography. label Dec 3, 2019
@LorenzHenk
Copy link
Author

LorenzHenk commented Dec 3, 2019

Just found several characters, that still escape. Please do not merge yet.

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 3, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 2022b68...db0c49b

bundle Size Change Size Gzip Change Gzip
Table ▲ +9 B (+0.01% ) 61.5 kB ▲ +9 B (+0.05% ) 19.2 kB
CardHeader ▲ +9 B (+0.01% ) 64 kB ▲ +7 B (+0.04% ) 20 kB
Autocomplete ▲ +9 B (+0.01% ) 127 kB ▲ +6 B (+0.02% ) 39.7 kB
ListItem ▲ +9 B (+0.01% ) 76 kB ▲ +6 B (+0.03% ) 23.6 kB
Skeleton ▲ +9 B (+0.01% ) 61.5 kB ▲ +6 B (+0.03% ) 19.3 kB
@material-ui/core ▲ +9 B (0.00% ) 354 kB ▲ +5 B (+0.01% ) 96.7 kB
@material-ui/core[umd] ▲ +9 B (0.00% ) 311 kB ▲ +5 B (+0.01% ) 89.6 kB
@material-ui/lab ▲ +9 B (+0.01% ) 173 kB ▲ +5 B (+0.01% ) 52.2 kB
Avatar ▲ +9 B (+0.01% ) 61.7 kB ▲ +5 B (+0.03% ) 19.3 kB
Backdrop ▲ +9 B (+0.01% ) 66.6 kB ▲ +5 B (+0.02% ) 20.5 kB
Button ▲ +9 B (+0.01% ) 78.3 kB ▲ +5 B (+0.02% ) 23.9 kB
CardActionArea ▲ +9 B (+0.01% ) 73.9 kB ▲ +5 B (+0.02% ) 23.2 kB
CardActions ▲ +9 B (+0.01% ) 60.9 kB ▲ +5 B (+0.03% ) 19 kB
CardMedia ▲ +9 B (+0.01% ) 61.2 kB ▲ +5 B (+0.03% ) 19.2 kB
Chip ▲ +9 B (+0.01% ) 81.4 kB ▲ +5 B (+0.02% ) 24.8 kB
Collapse ▲ +9 B (+0.01% ) 66.8 kB ▲ +5 B (+0.02% ) 20.6 kB
Container ▲ +9 B (+0.01% ) 62 kB ▲ +5 B (+0.03% ) 19.3 kB
Dialog ▲ +9 B (+0.01% ) 81.5 kB ▲ +5 B (+0.02% ) 25.4 kB
DialogActions ▲ +9 B (+0.01% ) 61 kB ▲ +5 B (+0.03% ) 19 kB
DialogContent ▲ +9 B (+0.01% ) 61.1 kB ▲ +5 B (+0.03% ) 19.1 kB
DialogTitle ▲ +9 B (+0.01% ) 63.2 kB ▲ +5 B (+0.03% ) 19.7 kB
Drawer ▲ +9 B (+0.01% ) 83.2 kB ▲ +5 B (+0.02% ) 25.2 kB
ExpansionPanel ▲ +9 B (+0.01% ) 70.2 kB ▲ +5 B (+0.02% ) 21.8 kB
ExpansionPanelActions ▲ +9 B (+0.01% ) 61 kB ▲ +5 B (+0.03% ) 19 kB
Fab ▲ +9 B (+0.01% ) 75.6 kB ▲ +5 B (+0.02% ) 23.5 kB
Fade ▲ +9 B (+0.04% ) 22.5 kB ▲ +5 B (+0.06% ) 7.71 kB
FilledInput ▲ +9 B (+0.01% ) 72.4 kB ▲ +5 B (+0.02% ) 22.4 kB
FormControl ▲ +9 B (+0.01% ) 63.3 kB ▲ +5 B (+0.03% ) 19.6 kB
FormControlLabel ▲ +9 B (+0.01% ) 64.4 kB ▲ +5 B (+0.02% ) 20.1 kB
FormHelperText ▲ +9 B (+0.01% ) 62.2 kB ▲ +5 B (+0.03% ) 19.4 kB
FormLabel ▲ +9 B (+0.01% ) 62.4 kB ▲ +5 B (+0.03% ) 19.2 kB
Grid ▲ +9 B (+0.01% ) 64 kB ▲ +5 B (+0.03% ) 20 kB
Hidden ▲ +9 B (+0.01% ) 64.8 kB ▲ +5 B (+0.02% ) 20.3 kB
IconButton ▲ +9 B (+0.01% ) 75 kB ▲ +5 B (+0.02% ) 23.3 kB
Input ▲ +9 B (+0.01% ) 71.3 kB ▲ +5 B (+0.02% ) 22.1 kB
LinearProgress ▲ +9 B (+0.01% ) 64.2 kB ▲ +5 B (+0.03% ) 20 kB
Link ▲ +9 B (+0.01% ) 65.5 kB ▲ +5 B (+0.02% ) 20.6 kB
List ▲ +9 B (+0.01% ) 61.3 kB ▲ +5 B (+0.03% ) 19 kB
ListItemAvatar ▲ +9 B (+0.01% ) 61 kB ▲ +5 B (+0.03% ) 19 kB
ListItemIcon ▲ +9 B (+0.01% ) 61.1 kB ▲ +5 B (+0.03% ) 19 kB
MenuItem ▲ +9 B (+0.01% ) 77 kB ▲ +5 B (+0.02% ) 23.9 kB
MenuList ▲ +9 B (+0.01% ) 64.9 kB ▲ +5 B (+0.02% ) 20.2 kB
NativeSelect ▲ +9 B (+0.01% ) 75.6 kB ▲ +5 B (+0.02% ) 23.7 kB
OutlinedInput ▲ +9 B (+0.01% ) 72.8 kB ▲ +5 B (+0.02% ) 22.6 kB
Paper ▲ +9 B (+0.01% ) 61.1 kB ▲ +5 B (+0.03% ) 19 kB
Rating ▲ +9 B (+0.01% ) 68.9 kB ▲ +5 B (+0.02% ) 22.1 kB
Select ▲ +9 B (+0.01% ) 113 kB ▲ +5 B (+0.01% ) 33.5 kB
Slide ▲ +9 B (+0.04% ) 24.5 kB ▲ +5 B (+0.06% ) 8.33 kB
Snackbar ▲ +9 B (+0.01% ) 76 kB ▲ +5 B (+0.02% ) 23.7 kB
SpeedDial ▲ +9 B (+0.01% ) 84.9 kB ▲ +5 B (+0.02% ) 26.7 kB
SpeedDialIcon ▲ +9 B (+0.01% ) 63.5 kB ▲ +5 B (+0.03% ) 19.9 kB
Step ▲ +9 B (+0.01% ) 61.5 kB ▲ +5 B (+0.03% ) 19.2 kB
StepButton ▲ +9 B (+0.01% ) 81.1 kB ▲ +5 B (+0.02% ) 25.5 kB
StepContent ▲ +9 B (+0.01% ) 67.9 kB ▲ +5 B (+0.02% ) 21.2 kB
StepLabel ▲ +9 B (+0.01% ) 67.5 kB ▲ +5 B (+0.02% ) 21.1 kB
SwipeableDrawer ▲ +9 B (+0.01% ) 90.6 kB ▲ +5 B (+0.02% ) 28 kB
TableBody ▲ +9 B (+0.01% ) 61 kB ▲ +5 B (+0.03% ) 19 kB
TableFooter ▲ +9 B (+0.01% ) 61 kB ▲ +5 B (+0.03% ) 19 kB
TableHead ▲ +9 B (+0.01% ) 61 kB ▲ +5 B (+0.03% ) 19 kB
TablePagination ▲ +9 B (+0.01% ) 140 kB ▲ +5 B (+0.01% ) 40.7 kB
TextField ▲ +9 B (+0.01% ) 122 kB ▲ +5 B (+0.01% ) 35.5 kB
ToggleButton ▲ +9 B (+0.01% ) 75 kB ▲ +5 B (+0.02% ) 23.7 kB
TreeItem ▲ +9 B (+0.01% ) 72.5 kB ▲ +5 B (+0.02% ) 22.8 kB
Typography ▲ +9 B (+0.01% ) 62.5 kB ▲ +5 B (+0.03% ) 19.5 kB
AppBar ▲ +9 B (+0.01% ) 62.7 kB ▲ +4 B (+0.02% ) 19.5 kB
Badge ▲ +9 B (+0.01% ) 64.2 kB ▲ +4 B (+0.02% ) 19.9 kB
BottomNavigation ▲ +9 B (+0.01% ) 61.3 kB ▲ +4 B (+0.02% ) 19.1 kB
BottomNavigationAction ▲ +9 B (+0.01% ) 74.3 kB ▲ +4 B (+0.02% ) 23.4 kB
Box ▲ +9 B (+0.01% ) 69.6 kB ▲ +4 B (+0.02% ) 21 kB
Breadcrumbs ▲ +9 B (+0.01% ) 66.9 kB ▲ +4 B (+0.02% ) 20.9 kB
ButtonBase ▲ +9 B (+0.01% ) 72.8 kB ▲ +4 B (+0.02% ) 22.8 kB
ButtonGroup ▲ +9 B (+0.01% ) 80.9 kB ▲ +4 B (+0.02% ) 24.8 kB
Card ▲ +9 B (+0.01% ) 61.6 kB ▲ +4 B (+0.02% ) 19.2 kB
CardContent ▲ +9 B (+0.01% ) 60.9 kB ▲ +4 B (+0.02% ) 19 kB
Checkbox ▲ +9 B (+0.01% ) 80.6 kB ▲ +4 B (+0.02% ) 25.4 kB
CircularProgress ▲ +9 B (+0.01% ) 63 kB ▲ +4 B (+0.02% ) 19.8 kB
CssBaseline ▲ +9 B (+0.02% ) 56.5 kB ▲ +4 B (+0.02% ) 17.6 kB
DialogContentText ▲ +9 B (+0.01% ) 62.9 kB ▲ +4 B (+0.02% ) 19.7 kB
Divider ▲ +9 B (+0.01% ) 61.5 kB ▲ +4 B (+0.02% ) 19.2 kB
docs.main ▲ +9 B (0.00% ) 609 kB ▲ +4 B (0.00% ) 194 kB
ExpansionPanelDetails ▲ +9 B (+0.01% ) 60.8 kB ▲ +4 B (+0.02% ) 19 kB
ExpansionPanelSummary ▲ +9 B (+0.01% ) 76.9 kB ▲ +4 B (+0.02% ) 24.2 kB
FormGroup ▲ +9 B (+0.01% ) 60.9 kB ▲ +4 B (+0.02% ) 19 kB
GridList ▲ +9 B (+0.01% ) 61.4 kB ▲ +4 B (+0.02% ) 19.2 kB
GridListTile ▲ +9 B (+0.01% ) 62.6 kB ▲ +4 B (+0.02% ) 19.5 kB
GridListTileBar ▲ +9 B (+0.01% ) 62.1 kB ▲ +4 B (+0.02% ) 19.4 kB
Grow ▲ +9 B (+0.04% ) 23.1 kB ▲ +4 B (+0.05% ) 7.83 kB
Icon ▲ +9 B (+0.01% ) 61.7 kB ▲ +4 B (+0.02% ) 19.2 kB
InputBase ▲ +9 B (+0.01% ) 69.4 kB ▲ +4 B (+0.02% ) 21.7 kB
InputLabel ▲ +9 B (+0.01% ) 64.2 kB ▲ +4 B (+0.02% ) 20 kB
ListItemSecondaryAction ▲ +9 B (+0.01% ) 60.9 kB ▲ +4 B (+0.02% ) 19 kB
ListItemText ▲ +9 B (+0.01% ) 63.9 kB ▲ +4 B (+0.02% ) 19.9 kB
ListSubheader ▲ +9 B (+0.01% ) 61.7 kB ▲ +4 B (+0.02% ) 19.3 kB
Menu ▲ +9 B (+0.01% ) 87.1 kB ▲ +4 B (+0.01% ) 26.8 kB
Radio ▲ +9 B (+0.01% ) 81.5 kB ▲ +4 B (+0.02% ) 25.6 kB
RadioGroup ▲ +9 B (+0.01% ) 62.1 kB ▲ +4 B (+0.02% ) 19.4 kB
SnackbarContent ▲ +9 B (+0.01% ) 64.5 kB ▲ +4 B (+0.02% ) 20.2 kB
SpeedDialAction ▲ +9 B (+0.01% ) 115 kB ▲ +4 B (+0.01% ) 36.5 kB
StepConnector ▲ +9 B (+0.01% ) 61.6 kB ▲ +4 B (+0.02% ) 19.3 kB
StepIcon ▲ +9 B (+0.01% ) 63.5 kB ▲ +4 B (+0.02% ) 19.7 kB
Stepper ▲ +9 B (+0.01% ) 63.6 kB ▲ +4 B (+0.02% ) 20 kB
styles/createMuiTheme ▲ +9 B (+0.06% ) 15.7 kB ▲ +4 B (+0.07% ) 5.47 kB
SvgIcon ▲ +9 B (+0.01% ) 61.9 kB ▲ +4 B (+0.02% ) 19.3 kB
Switch ▲ +9 B (+0.01% ) 80 kB ▲ +4 B (+0.02% ) 25.1 kB
Tab ▲ +9 B (+0.01% ) 75.2 kB ▲ +4 B (+0.02% ) 23.7 kB
TableCell ▲ +9 B (+0.01% ) 62.9 kB ▲ +4 B (+0.02% ) 19.7 kB
TableRow ▲ +9 B (+0.01% ) 61.4 kB ▲ +4 B (+0.02% ) 19.1 kB
TableSortLabel ▲ +9 B (+0.01% ) 76.2 kB ▲ +4 B (+0.02% ) 23.9 kB
Tabs ▲ +9 B (+0.01% ) 84.3 kB ▲ +4 B (+0.02% ) 26.5 kB
ToggleButtonGroup ▲ +9 B (+0.01% ) 62.1 kB ▲ +4 B (+0.02% ) 19.4 kB
Toolbar ▲ +9 B (+0.01% ) 61.2 kB ▲ +4 B (+0.02% ) 19.1 kB
Tooltip ▲ +9 B (+0.01% ) 99.4 kB ▲ +4 B (+0.01% ) 31.4 kB
TreeView ▲ +9 B (+0.01% ) 65.3 kB ▲ +4 B (+0.02% ) 20.4 kB
Zoom ▲ +9 B (+0.04% ) 22.5 kB ▲ +4 B (+0.05% ) 7.71 kB
InputAdornment ▲ +9 B (+0.01% ) 64 kB ▲ +3 B (+0.01% ) 20 kB
MobileStepper ▲ +9 B (+0.01% ) 66.6 kB ▲ +3 B (+0.01% ) 20.8 kB
Popover ▲ +9 B (+0.01% ) 81.5 kB ▲ +3 B (+0.01% ) 25.1 kB
Slider ▲ +9 B (+0.01% ) 74.5 kB ▲ +3 B (+0.01% ) 23.3 kB
@material-ui/styles -- 51 kB -- 15.3 kB
@material-ui/system -- 14.8 kB -- 4.06 kB
ClickAwayListener -- 3.87 kB -- 1.56 kB
colorManipulator -- 3.85 kB -- 1.52 kB
docs.landing -- 52.4 kB -- 11.4 kB
Modal -- 14.2 kB -- 4.99 kB
NoSsr -- 2.19 kB -- 1.03 kB
Popper -- 28.6 kB -- 10.2 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.43 kB -- 1.67 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
useAutocomplete -- 12.4 kB -- 4.56 kB
useMediaQuery -- 2.49 kB -- 1.05 kB

Generated by 🚫 dangerJS against db0c49b

Adjust lineHeight to support special characters
db0c49b 
Supported special characters: Ű}Âg!”)%)#
@LorenzHenk
Copy link
Author

LorenzHenk commented Dec 3, 2019

Added support for these characters: Ű}Âg!”)%)#

@oliviertassinari oliviertassinari added this to the v4.8.0 milestone Dec 3, 2019
@oliviertassinari oliviertassinari added the on hold There is a blocker, we need to wait. label Dec 3, 2019
@oliviertassinari oliviertassinari mentioned this pull request Dec 5, 2019
Closed
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 5, 2019 •
edited by mbrookes
Loading

@LorenzHenk Thanks, we're gonna wait for the next minor, I think that this bug fix is too sensitive to go in a patch.

@oliviertassinari oliviertassinari added PR: ready to ship and removed on hold There is a blocker, we need to wait. labels Dec 7, 2019
@oliviertassinari oliviertassinari merged commit f124bff into mui:master Dec 7, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 7, 2019

@LorenzHenk Thank you

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

scope: typography Changes related to typography.

Projects

None yet

Milestone

v4.8.0

Development

Successfully merging this pull request may close these issues.

[Typography] Ascender/descender escape line-height

3 participants

@LorenzHenk @mui-pr-bot @oliviertassinari