[core] Add react-is dependency #18551
Conversation
oliviertassinari
changed the title
oliviertassinari
left a comment
oliviertassinari
left a comment
There was a problem hiding this comment.
Same problem with the lab.
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
Thanks! You need to run yarn again in the monorepo. yarn v1 has sometimes issues with yarn workspace * add.
Can't wait for yarn v2 which catches these issues at runtime.
This dependency is called in Menu.js but is not listed in package.json
|
No bundle size changes comparing 73fb52a...7311379 |
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
packages/material-ui-lab/package.json needs it as well
I also noticed that material-ui-utils is using react 16.8.0 and react-utils 16.8.6. Is this wanted or it's an issue ? @eps1lon |
oliviertassinari
added
type: bug
|
@HeadFox It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
|
I'm using material-ui since the v1 ! |
|
@HeadFox awesome. If you could change, add, or remove one thing in the framework, what would it be? |
4 participants
This dependency is called in Menu.js but is not listed in package.json
I detected this problem when I runned a project with yarn berry (v2) using pnp.
The Menu.js component is using 'isFragment' function from the react-is library.
The only package.json that have react-is is in @material-ui/utils.
This change is also related to the #17317