Skip to content

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 18, 2019

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 18, 2019

No bundle size changes comparing 15e3336...00166f2

Generated by 🚫 dangerJS against 00166f2

Co-Authored-By: Minh Nguyen <[email protected]>
@mbrookes mbrookes changed the title test] Check a11y tree inclusion in CI only [test] Check a11y tree inclusion in CI only Nov 18, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before > 2639 passing (50s)
After > 2637 passing (30s)

For curiosity, I have tried this diff, same output:

diff --git a/node_modules/@testing-library/dom/dist/role-helpers.js b/node_modules/@testing-library/dom/dist/role-helpers.js
- if (window.getComputedStyle(element).display === 'none') {
+ if (({}).display === 'none') {
    return true;
  }

...


- if (window.getComputedStyle(element).visibility === 'hidden') {
+ if (({}).visibility === 'hidden') {
    return true;
  }

Great job! Performance issue with testing-library: solved 👏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants