Skip to content

[Popper] Use context for RTL support #18381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2019
Merged

[Popper] Use context for RTL support #18381

merged 2 commits into from
Nov 16, 2019

Conversation

@MisterQH
Copy link
Contributor

@MisterQH MisterQH commented Nov 15, 2019

Fixes #18373

@MisterQH MisterQH changed the title Use document instead of window for SSR Use document instead of window for SSR in Popper Nov 15, 2019
@MisterQH MisterQH changed the title Use document instead of window for SSR in Popper Use document instead of window in Popper for SSR Nov 15, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 15, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 64ae0c6...f4aa2aa

bundle Size Change Size Gzip Change Gzip
Popper ▲ +192 B (+0.67% ) 28.6 kB ▲ +41 B (+0.40% ) 10.2 kB
@material-ui/core[umd] ▼ -40 B (-0.01% ) 310 kB ▲ +1 B (0.00% ) 89.2 kB
@material-ui/lab ▼ -23 B (-0.01% ) 171 kB ▲ +21 B (+0.04% ) 51.7 kB
Tooltip ▼ -23 B (-0.02% ) 99 kB ▲ +13 B (+0.04% ) 31.3 kB
Autocomplete ▼ -23 B (-0.02% ) 126 kB ▲ +9 B (+0.02% ) 39.9 kB
@material-ui/core ▼ -23 B (-0.01% ) 351 kB ▲ +7 B (+0.01% ) 95.9 kB
SpeedDialAction ▼ -23 B (-0.02% ) 115 kB ▲ +2 B (+0.01% ) 36.4 kB
docs.main ▼ -19 B (-0.00% ) 606 kB ▼ -9 B (-0.00% ) 193 kB
@material-ui/styles -- 50.8 kB -- 15.4 kB
@material-ui/system -- 14.8 kB -- 4.06 kB
AppBar -- 62.3 kB -- 19.5 kB
Avatar -- 61.3 kB -- 19.3 kB
Backdrop -- 66.3 kB -- 20.4 kB
Badge -- 63.9 kB -- 19.8 kB
BottomNavigation -- 60.9 kB -- 19.1 kB
BottomNavigationAction -- 74 kB -- 23.4 kB
Box -- 69.3 kB -- 21 kB
Breadcrumbs -- 66.5 kB -- 20.9 kB
Button -- 77.9 kB -- 23.8 kB
ButtonBase -- 72.5 kB -- 22.7 kB
ButtonGroup -- 80.5 kB -- 24.7 kB
Card -- 61.3 kB -- 19.2 kB
CardActionArea -- 73.5 kB -- 23.2 kB
CardActions -- 60.6 kB -- 19 kB
CardContent -- 60.5 kB -- 18.9 kB
CardHeader -- 63.6 kB -- 20 kB
CardMedia -- 60.9 kB -- 19.1 kB
Checkbox -- 80.3 kB -- 25.2 kB
Chip -- 81 kB -- 24.7 kB
CircularProgress -- 62.6 kB -- 19.7 kB
ClickAwayListener -- 3.87 kB -- 1.56 kB
Collapse -- 66.4 kB -- 20.5 kB
colorManipulator -- 3.83 kB -- 1.52 kB
Container -- 61.7 kB -- 19.3 kB
CssBaseline -- 56.1 kB -- 17.5 kB
Dialog -- 81.1 kB -- 25.1 kB
DialogActions -- 60.6 kB -- 19 kB
DialogContent -- 60.8 kB -- 19 kB
DialogContentText -- 62.6 kB -- 19.6 kB
DialogTitle -- 62.8 kB -- 19.7 kB
Divider -- 61.1 kB -- 19.2 kB
docs.landing -- 55.8 kB -- 14.3 kB
Drawer -- 82.8 kB -- 25.6 kB
ExpansionPanel -- 69.7 kB -- 21.7 kB
ExpansionPanelActions -- 60.6 kB -- 19 kB
ExpansionPanelDetails -- 60.5 kB -- 18.9 kB
ExpansionPanelSummary -- 76.6 kB -- 24.1 kB
Fab -- 75.3 kB -- 23.4 kB
Fade -- 22.1 kB -- 7.63 kB
FilledInput -- 72.1 kB -- 22.3 kB
FormControl -- 62.9 kB -- 19.5 kB
FormControlLabel -- 64 kB -- 20.1 kB
FormGroup -- 60.5 kB -- 18.9 kB
FormHelperText -- 61.8 kB -- 19.3 kB
FormLabel -- 62 kB -- 19.2 kB
Grid -- 63.6 kB -- 19.9 kB
GridList -- 61 kB -- 19.1 kB
GridListTile -- 62.3 kB -- 19.5 kB
GridListTileBar -- 61.8 kB -- 19.3 kB
Grow -- 22.7 kB -- 7.76 kB
Hidden -- 64.5 kB -- 20.2 kB
Icon -- 61.3 kB -- 19.2 kB
IconButton -- 74.6 kB -- 23.2 kB
Input -- 71 kB -- 22.1 kB
InputAdornment -- 63.6 kB -- 20 kB
InputBase -- 69.1 kB -- 21.6 kB
InputLabel -- 63.9 kB -- 19.9 kB
LinearProgress -- 63.9 kB -- 19.9 kB
Link -- 65.1 kB -- 20.6 kB
List -- 60.9 kB -- 18.9 kB
ListItem -- 75.6 kB -- 23.6 kB
ListItemAvatar -- 60.6 kB -- 19 kB
ListItemIcon -- 60.7 kB -- 19 kB
ListItemSecondaryAction -- 60.5 kB -- 18.9 kB
ListItemText -- 63.5 kB -- 20 kB
ListSubheader -- 61.3 kB -- 19.2 kB
Menu -- 86.7 kB -- 27.2 kB
MenuItem -- 76.6 kB -- 23.9 kB
MenuList -- 64.5 kB -- 20.1 kB
MobileStepper -- 66.3 kB -- 20.7 kB
Modal -- 14.2 kB -- 4.96 kB
NativeSelect -- 75.3 kB -- 23.7 kB
NoSsr -- 2.19 kB -- 1.04 kB
OutlinedInput -- 72.6 kB -- 22.5 kB
Paper -- 60.8 kB -- 18.9 kB
Popover -- 81.1 kB -- 25 kB
Portal -- 2.87 kB -- 1.3 kB
Radio -- 81.1 kB -- 25.5 kB
RadioGroup -- 61.8 kB -- 19.3 kB
Rating -- 68.5 kB -- 21.9 kB
RootRef -- 4.43 kB -- 1.67 kB
Select -- 113 kB -- 33.4 kB
Skeleton -- 61 kB -- 19.2 kB
Slide -- 24.2 kB -- 8.24 kB
Slider -- 74.1 kB -- 23.4 kB
Snackbar -- 75.7 kB -- 23.6 kB
SnackbarContent -- 64.2 kB -- 20.2 kB
SpeedDial -- 84.5 kB -- 26.6 kB
SpeedDialIcon -- 63.1 kB -- 19.8 kB
Step -- 61.1 kB -- 19.2 kB
StepButton -- 80.8 kB -- 25.3 kB
StepConnector -- 61.3 kB -- 19.2 kB
StepContent -- 67.5 kB -- 21 kB
StepIcon -- 63.2 kB -- 19.6 kB
StepLabel -- 67.1 kB -- 21 kB
Stepper -- 63.3 kB -- 19.9 kB
styles/createMuiTheme -- 15.3 kB -- 5.4 kB
SvgIcon -- 61.6 kB -- 19.2 kB
SwipeableDrawer -- 90.2 kB -- 28 kB
Switch -- 79.6 kB -- 24.7 kB
Tab -- 74.8 kB -- 23.7 kB
Table -- 61.1 kB -- 19.1 kB
TableBody -- 60.6 kB -- 19 kB
TableCell -- 62.6 kB -- 19.6 kB
TableFooter -- 60.6 kB -- 19 kB
TableHead -- 60.6 kB -- 19 kB
TablePagination -- 139 kB -- 40.6 kB
TableRow -- 61.1 kB -- 19.1 kB
TableSortLabel -- 75.8 kB -- 24 kB
Tabs -- 83.9 kB -- 26.7 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
TextField -- 121 kB -- 35.5 kB
ToggleButton -- 74.6 kB -- 23.5 kB
ToggleButtonGroup -- 61.7 kB -- 19.4 kB
Toolbar -- 60.9 kB -- 19.1 kB
TreeItem -- 72.1 kB -- 22.7 kB
TreeView -- 64.9 kB -- 20.3 kB
Typography -- 62.2 kB -- 19.4 kB
useAutocomplete -- 12.1 kB -- 4.47 kB
useMediaQuery -- 2.49 kB -- 1.05 kB
Zoom -- 22.2 kB -- 7.64 kB

Generated by 🚫 dangerJS against f4aa2aa

eps1lon
eps1lon reviewed Nov 15, 2019
View reviewed changes
@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. PR: needs revision component: Popper The React component. See <Popup> for the latest version. labels Nov 15, 2019
@oliviertassinari oliviertassinari changed the title Use document instead of window in Popper for SSR [Popper] Use context for RTL support Nov 16, 2019
@oliviertassinari oliviertassinari merged commit 7875ae3 into mui:master Nov 16, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 16, 2019

@MisterQH Thank you. The gzip change is almost negligible:

+41 B (+0.40% )

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@eps1lon eps1lon eps1lon left review comments

Assignees

No one assigned

Labels

component: Popper The React component. See <Popup> for the latest version. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Popper.js document is not defined with SSR

4 participants

@MisterQH @mui-pr-bot @oliviertassinari @eps1lon