Skip to content

[ButtonBase] Fix space calling onClick on keyDown instead of keyUp #18319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 12, 2019
Merged

[ButtonBase] Fix space calling onClick on keyDown instead of keyUp #18319

merged 4 commits into from
Nov 12, 2019

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 11, 2019

No description provided.

@eps1lon eps1lon added type: bug It doesn't behave as expected. accessibility a11y component: ButtonBase The React component. labels Nov 11, 2019
eps1lon
eps1lon commented Nov 11, 2019
View reviewed changes
packages/material-ui/src/Chip/Chip.test.js
key: ' ',
};
wrapper.find('div').simulate('keyDown', spaceKeyDown);
assert.strictEqual(preventDefaultSpy.callCount, 2);
Copy link
Member Author

@eps1lon eps1lon Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to extract the testing-library port from #18271 to see that everything is working.

@eps1lon eps1lon force-pushed the fix/ButtonBase/space-click branch from 64134f6 to 2f0601a Compare November 11, 2019 15:20
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 11, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 0f5a304...6d3911e

bundle Size Change Size Gzip Change Gzip
Checkbox ▲ +92 B (+0.11% ) 80.2 kB ▲ +11 B (+0.04% ) 25.1 kB
ListItem ▲ +92 B (+0.12% ) 75.5 kB ▲ +10 B (+0.04% ) 23.5 kB
MenuItem ▲ +92 B (+0.12% ) 76.5 kB ▲ +10 B (+0.04% ) 23.8 kB
SpeedDialAction ▲ +92 B (+0.08% ) 114 kB ▲ +10 B (+0.03% ) 36 kB
StepButton ▲ +92 B (+0.11% ) 80.7 kB ▲ +10 B (+0.04% ) 25.3 kB
TableSortLabel ▲ +92 B (+0.12% ) 75.7 kB ▲ +10 B (+0.04% ) 23.9 kB
Tabs ▲ +92 B (+0.11% ) 83.8 kB ▲ +10 B (+0.04% ) 26.7 kB
BottomNavigationAction ▲ +92 B (+0.12% ) 73.9 kB ▲ +9 B (+0.04% ) 23.3 kB
CardActionArea ▲ +92 B (+0.13% ) 73.4 kB ▲ +9 B (+0.04% ) 23.2 kB
ExpansionPanelSummary ▲ +92 B (+0.12% ) 76.5 kB ▲ +9 B (+0.04% ) 24.1 kB
Fab ▲ +92 B (+0.12% ) 75.2 kB ▲ +9 B (+0.04% ) 23.3 kB
IconButton ▲ +92 B (+0.12% ) 74.5 kB ▲ +9 B (+0.04% ) 23.2 kB
Switch ▲ +92 B (+0.12% ) 79.5 kB ▲ +9 B (+0.04% ) 24.7 kB
Tab ▲ +92 B (+0.12% ) 74.7 kB ▲ +9 B (+0.04% ) 23.7 kB
Button ▲ +92 B (+0.12% ) 77.8 kB ▲ +8 B (+0.03% ) 23.8 kB
ButtonBase ▲ +92 B (+0.13% ) 72.3 kB ▲ +8 B (+0.04% ) 22.6 kB
docs.main ▲ +92 B (+0.02% ) 605 kB ▲ +8 B (0.00% ) 193 kB
Radio ▲ +92 B (+0.11% ) 81 kB ▲ +8 B (+0.03% ) 25.4 kB
SpeedDial ▲ +92 B (+0.11% ) 84.4 kB ▲ +8 B (+0.03% ) 26.6 kB
ToggleButton ▲ +92 B (+0.12% ) 74.5 kB ▲ +8 B (+0.03% ) 23.5 kB
ButtonGroup ▲ +92 B (+0.11% ) 80.4 kB ▲ +7 B (+0.03% ) 24.7 kB
TablePagination ▲ +92 B (+0.07% ) 139 kB ▲ +1 B (0.00% ) 40.5 kB
@material-ui/lab ▼ -77 B (-0.05% ) 170 kB ▼ -42 B (-0.08% ) 51.2 kB
Autocomplete ▼ -77 B (-0.06% ) 126 kB ▼ -38 B (-0.10% ) 39.8 kB
@material-ui/core[umd] ▼ -77 B (-0.02% ) 309 kB ▼ -28 B (-0.03% ) 88.9 kB
Chip ▼ -77 B (-0.10% ) 80.9 kB ▼ -28 B (-0.11% ) 24.7 kB
@material-ui/core ▼ -77 B (-0.02% ) 349 kB ▼ -22 B (-0.02% ) 95.6 kB
@material-ui/styles -- 50.8 kB -- 15.4 kB
@material-ui/system -- 14.8 kB -- 4.06 kB
AppBar -- 62.2 kB -- 19.5 kB
Avatar -- 61.2 kB -- 19.3 kB
Backdrop -- 66.2 kB -- 20.4 kB
Badge -- 63.8 kB -- 19.7 kB
BottomNavigation -- 60.8 kB -- 19 kB
Box -- 69.2 kB -- 20.9 kB
Breadcrumbs -- 66.4 kB -- 20.8 kB
Card -- 61.2 kB -- 19.1 kB
CardActions -- 60.5 kB -- 18.9 kB
CardContent -- 60.4 kB -- 18.9 kB
CardHeader -- 63.5 kB -- 20 kB
CardMedia -- 60.8 kB -- 19.1 kB
CircularProgress -- 62.5 kB -- 19.7 kB
ClickAwayListener -- 3.87 kB -- 1.56 kB
Collapse -- 66.3 kB -- 20.5 kB
colorManipulator -- 3.83 kB -- 1.52 kB
Container -- 61.6 kB -- 19.2 kB
CssBaseline -- 56 kB -- 17.5 kB
Dialog -- 80.9 kB -- 25.1 kB
DialogActions -- 60.5 kB -- 18.9 kB
DialogContent -- 60.6 kB -- 19 kB
DialogContentText -- 62.5 kB -- 19.6 kB
DialogTitle -- 62.7 kB -- 19.7 kB
Divider -- 61 kB -- 19.2 kB
docs.landing -- 55.6 kB -- 14.6 kB
Drawer -- 82.7 kB -- 25.6 kB
ExpansionPanel -- 69.6 kB -- 21.7 kB
ExpansionPanelActions -- 60.5 kB -- 19 kB
ExpansionPanelDetails -- 60.4 kB -- 18.9 kB
Fade -- 22 kB -- 7.6 kB
FilledInput -- 72 kB -- 22.3 kB
FormControl -- 62.8 kB -- 19.5 kB
FormControlLabel -- 63.9 kB -- 20.1 kB
FormGroup -- 60.4 kB -- 18.9 kB
FormHelperText -- 61.7 kB -- 19.3 kB
FormLabel -- 61.9 kB -- 19.1 kB
Grid -- 63.5 kB -- 19.9 kB
GridList -- 60.9 kB -- 19.1 kB
GridListTile -- 62.2 kB -- 19.5 kB
GridListTileBar -- 61.6 kB -- 19.3 kB
Grow -- 22.6 kB -- 7.72 kB
Hidden -- 64.5 kB -- 20.2 kB
Icon -- 61.2 kB -- 19.2 kB
Input -- 70.9 kB -- 22.1 kB
InputAdornment -- 63.5 kB -- 20 kB
InputBase -- 69 kB -- 21.6 kB
InputLabel -- 63.7 kB -- 19.8 kB
LinearProgress -- 63.8 kB -- 19.9 kB
Link -- 65 kB -- 20.6 kB
List -- 60.8 kB -- 18.9 kB
ListItemAvatar -- 60.5 kB -- 18.9 kB
ListItemIcon -- 60.6 kB -- 19 kB
ListItemSecondaryAction -- 60.4 kB -- 18.9 kB
ListItemText -- 63.4 kB -- 19.9 kB
ListSubheader -- 61.2 kB -- 19.2 kB
Menu -- 86.6 kB -- 27.2 kB
MenuList -- 64.4 kB -- 20.1 kB
MobileStepper -- 66.2 kB -- 20.6 kB
Modal -- 14.2 kB -- 4.96 kB
NativeSelect -- 75.2 kB -- 23.7 kB
NoSsr -- 2.19 kB -- 1.04 kB
OutlinedInput -- 72.5 kB -- 22.5 kB
Paper -- 60.7 kB -- 18.9 kB
Popover -- 81 kB -- 25 kB
Popper -- 28.5 kB -- 10.2 kB
Portal -- 2.87 kB -- 1.3 kB
RadioGroup -- 61.7 kB -- 19.3 kB
Rating -- 68.4 kB -- 21.9 kB
RootRef -- 4.43 kB -- 1.67 kB
Select -- 112 kB -- 33.4 kB
Skeleton -- 60.9 kB -- 19.1 kB
Slide -- 24.1 kB -- 8.21 kB
Slider -- 74 kB -- 23.3 kB
Snackbar -- 75.6 kB -- 23.5 kB
SnackbarContent -- 64.1 kB -- 20.1 kB
SpeedDialIcon -- 63 kB -- 19.8 kB
Step -- 61 kB -- 19.1 kB
StepConnector -- 61.1 kB -- 19.2 kB
StepContent -- 67.4 kB -- 21 kB
StepIcon -- 63.1 kB -- 19.6 kB
StepLabel -- 67 kB -- 21 kB
Stepper -- 63.2 kB -- 19.9 kB
styles/createMuiTheme -- 15.2 kB -- 5.36 kB
SvgIcon -- 61.5 kB -- 19.1 kB
SwipeableDrawer -- 90.1 kB -- 28 kB
Table -- 61 kB -- 19.1 kB
TableBody -- 60.5 kB -- 18.9 kB
TableCell -- 62.5 kB -- 19.6 kB
TableFooter -- 60.5 kB -- 18.9 kB
TableHead -- 60.5 kB -- 18.9 kB
TableRow -- 61 kB -- 19.1 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
TextField -- 121 kB -- 35.4 kB
ToggleButtonGroup -- 61.6 kB -- 19.4 kB
Toolbar -- 60.8 kB -- 19 kB
Tooltip -- 97.6 kB -- 30.9 kB
TreeItem -- 72 kB -- 22.7 kB
TreeView -- 64.8 kB -- 20.3 kB
Typography -- 62.1 kB -- 19.3 kB
useAutocomplete -- 12.1 kB -- 4.47 kB
useMediaQuery -- 2.49 kB -- 1.05 kB
Zoom -- 22.1 kB -- 7.6 kB

Generated by 🚫 dangerJS against 6d3911e

eps1lon
eps1lon commented Nov 12, 2019
View reviewed changes
eps1lon
eps1lon commented Nov 12, 2019
View reviewed changes
@eps1lon eps1lon merged commit 2713be4 into mui:master Nov 12, 2019
@eps1lon eps1lon deleted the fix/ButtonBase/space-click branch November 12, 2019 12:33
@oliviertassinari oliviertassinari mentioned this pull request Nov 12, 2019
Closed
2 tasks
@oliviertassinari oliviertassinari mentioned this pull request Dec 5, 2019
Closed
2 tasks
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

accessibility a11y component: ButtonBase The React component. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eps1lon @mui-pr-bot