[Autocomplete] Remove aria-activedescendant #18281

oliviertassinari · 2019-11-09T12:58:53Z

mui-pr-bot · 2019-11-09T13:09:40Z

Details of bundle changes.

Comparing: 3d393bf...a43eb78

bundle	Size Change	Size	Gzip Change	Gzip
useAutocomplete	▼ -87 B (-0.71% )	12.1 kB	▼ -25 B (-0.56% )	4.47 kB
@material-ui/lab	▼ -87 B (-0.05% )	170 kB	▼ -24 B (-0.05% )	51.2 kB
Autocomplete	▼ -87 B (-0.07% )	126 kB	▼ -20 B (-0.05% )	39.8 kB
@material-ui/core	--	349 kB	--	95.6 kB
@material-ui/core[umd]	--	309 kB	--	88.9 kB
@material-ui/styles	--	50.8 kB	--	15.4 kB
@material-ui/system	--	14.8 kB	--	4.06 kB
AppBar	--	62.2 kB	--	19.5 kB
Avatar	--	61.2 kB	--	19.3 kB
Backdrop	--	66.2 kB	--	20.4 kB
Badge	--	63.8 kB	--	19.7 kB
BottomNavigation	--	60.8 kB	--	19 kB
BottomNavigationAction	--	73.8 kB	--	23.3 kB
Box	--	69.2 kB	--	20.9 kB
Breadcrumbs	--	66.4 kB	--	20.8 kB
Button	--	77.8 kB	--	23.8 kB
ButtonBase	--	72.3 kB	--	22.6 kB
ButtonGroup	--	80.3 kB	--	24.6 kB
Card	--	61.2 kB	--	19.1 kB
CardActionArea	--	73.4 kB	--	23.1 kB
CardActions	--	60.5 kB	--	18.9 kB
CardContent	--	60.4 kB	--	18.9 kB
CardHeader	--	63.5 kB	--	20 kB
CardMedia	--	60.8 kB	--	19.1 kB
Checkbox	--	80.1 kB	--	25.1 kB
Chip	--	81 kB	--	24.7 kB
CircularProgress	--	62.5 kB	--	19.7 kB
ClickAwayListener	--	3.87 kB	--	1.56 kB
Collapse	--	66.3 kB	--	20.5 kB
colorManipulator	--	3.83 kB	--	1.52 kB
Container	--	61.6 kB	--	19.2 kB
CssBaseline	--	56 kB	--	17.5 kB
Dialog	--	80.9 kB	--	25.1 kB
DialogActions	--	60.5 kB	--	18.9 kB
DialogContent	--	60.6 kB	--	19 kB
DialogContentText	--	62.5 kB	--	19.6 kB
DialogTitle	--	62.7 kB	--	19.7 kB
Divider	--	61 kB	--	19.2 kB
docs.landing	--	55.6 kB	--	14.6 kB
docs.main	--	605 kB	--	192 kB
Drawer	--	82.7 kB	--	25.6 kB
ExpansionPanel	--	69.6 kB	--	21.7 kB
ExpansionPanelActions	--	60.5 kB	--	19 kB
ExpansionPanelDetails	--	60.4 kB	--	18.9 kB
ExpansionPanelSummary	--	76.4 kB	--	24.1 kB
Fab	--	75.1 kB	--	23.3 kB
Fade	--	22 kB	--	7.6 kB
FilledInput	--	72 kB	--	22.3 kB
FormControl	--	62.8 kB	--	19.5 kB
FormControlLabel	--	63.9 kB	--	20.1 kB
FormGroup	--	60.4 kB	--	18.9 kB
FormHelperText	--	61.7 kB	--	19.3 kB
FormLabel	--	61.9 kB	--	19.1 kB
Grid	--	63.5 kB	--	19.9 kB
GridList	--	60.9 kB	--	19.1 kB
GridListTile	--	62.2 kB	--	19.5 kB
GridListTileBar	--	61.6 kB	--	19.3 kB
Grow	--	22.6 kB	--	7.72 kB
Hidden	--	64.5 kB	--	20.2 kB
Icon	--	61.2 kB	--	19.2 kB
IconButton	--	74.4 kB	--	23.2 kB
Input	--	70.9 kB	--	22.1 kB
InputAdornment	--	63.5 kB	--	20 kB
InputBase	--	69 kB	--	21.6 kB
InputLabel	--	63.7 kB	--	19.8 kB
LinearProgress	--	63.8 kB	--	19.9 kB
Link	--	65 kB	--	20.6 kB
List	--	60.8 kB	--	18.9 kB
ListItem	--	75.4 kB	--	23.5 kB
ListItemAvatar	--	60.5 kB	--	18.9 kB
ListItemIcon	--	60.6 kB	--	19 kB
ListItemSecondaryAction	--	60.4 kB	--	18.9 kB
ListItemText	--	63.4 kB	--	19.9 kB
ListSubheader	--	61.2 kB	--	19.2 kB
Menu	--	86.6 kB	--	27.2 kB
MenuItem	--	76.4 kB	--	23.8 kB
MenuList	--	64.4 kB	--	20.1 kB
MobileStepper	--	66.2 kB	--	20.6 kB
Modal	--	14.2 kB	--	4.96 kB
NativeSelect	--	75.2 kB	--	23.7 kB
NoSsr	--	2.19 kB	--	1.04 kB
OutlinedInput	--	72.5 kB	--	22.5 kB
Paper	--	60.7 kB	--	18.9 kB
Popover	--	81 kB	--	25 kB
Popper	--	28.5 kB	--	10.2 kB
Portal	--	2.87 kB	--	1.3 kB
Radio	--	81 kB	--	25.4 kB
RadioGroup	--	61.7 kB	--	19.3 kB
Rating	--	68.4 kB	--	21.9 kB
RootRef	--	4.43 kB	--	1.67 kB
Select	--	112 kB	--	33.4 kB
Skeleton	--	60.9 kB	--	19.1 kB
Slide	--	24.1 kB	--	8.21 kB
Slider	--	74 kB	--	23.3 kB
Snackbar	--	75.6 kB	--	23.5 kB
SnackbarContent	--	64.1 kB	--	20.1 kB
SpeedDial	--	84.3 kB	--	26.6 kB
SpeedDialAction	--	114 kB	--	36 kB
SpeedDialIcon	--	63 kB	--	19.8 kB
Step	--	61 kB	--	19.1 kB
StepButton	--	80.6 kB	--	25.3 kB
StepConnector	--	61.1 kB	--	19.2 kB
StepContent	--	67.4 kB	--	21 kB
StepIcon	--	63.1 kB	--	19.6 kB
StepLabel	--	67 kB	--	21 kB
Stepper	--	63.2 kB	--	19.9 kB
styles/createMuiTheme	--	15.2 kB	--	5.36 kB
SvgIcon	--	61.5 kB	--	19.1 kB
SwipeableDrawer	--	90.1 kB	--	28 kB
Switch	--	79.4 kB	--	24.7 kB
Tab	--	74.6 kB	--	23.6 kB
Table	--	61 kB	--	19.1 kB
TableBody	--	60.5 kB	--	18.9 kB
TableCell	--	62.5 kB	--	19.6 kB
TableFooter	--	60.5 kB	--	18.9 kB
TableHead	--	60.5 kB	--	18.9 kB
TablePagination	--	139 kB	--	40.5 kB
TableRow	--	61 kB	--	19.1 kB
TableSortLabel	--	75.6 kB	--	23.9 kB
Tabs	--	83.7 kB	--	26.7 kB
TextareaAutosize	--	5.06 kB	--	2.11 kB
TextField	--	121 kB	--	35.4 kB
ToggleButton	--	74.4 kB	--	23.5 kB
ToggleButtonGroup	--	61.6 kB	--	19.4 kB
Toolbar	--	60.8 kB	--	19 kB
Tooltip	--	97.6 kB	--	30.9 kB
TreeItem	--	72 kB	--	22.7 kB
TreeView	--	64.8 kB	--	20.3 kB
Typography	--	62.1 kB	--	19.3 kB
useMediaQuery	--	2.49 kB	--	1.05 kB
Zoom	--	22.1 kB	--	7.6 kB

Generated by 🚫 dangerJS against a43eb78

oliviertassinari · 2019-11-10T12:05:46Z

packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js

    setDefaultId(`mui-autocomplete-${Math.round(Math.random() * 1e5)}`);
  }, []);

-  const popperRef = React.useRef(null);


oliviertassinari · 2019-11-10T12:06:09Z

packages/material-ui-lab/src/Autocomplete/Autocomplete.test.js

      const { getAllByRole, getByRole } = render(
        <Autocomplete
-          options={['one', 'two  ']}
+          options={['one', 'two']}


normalize the options in this test file

oliviertassinari · 2019-11-10T12:13:01Z

packages/material-ui-lab/src/useAutocomplete/useAutocomplete.js

      // if open then this is handled imperativeley so don't let react override
      // only have an opinion about this when closed
-      'aria-activedescendant': popupOpen ? undefined : null,
+      'aria-activedescendant': popupOpen ? '' : null,


I haven't looked in detail how React handles undefined vs null. One key element is that, as far as I know, React doesn't diff with the DOM, but with the preview tree representation, he has. I suspect treats both values the same way, hence doesn't apply a diff. In any case, our test cases are our belt and straps.

oliviertassinari added accessibility a11y scope: autocomplete Changes related to the autocomplete. This includes ComboBox. labels Nov 9, 2019

oliviertassinari requested a review from eps1lon November 9, 2019 12:58

oliviertassinari commented Nov 10, 2019

View reviewed changes

oliviertassinari added the PR: ready to ship label Nov 10, 2019

[Autocomplete] Remove aria-activedescendant

a43eb78

oliviertassinari force-pushed the autocomplete-remove-activedescendant branch from 9b4a2f0 to a43eb78 Compare November 11, 2019 16:40

oliviertassinari merged commit 0f5a304 into mui:master Nov 12, 2019

snyk-bot mentioned this pull request Jan 7, 2020

[Snyk] Upgrade @material-ui/core from 4.4.0 to 4.8.2 srdjan-19/rent-a-car-service#3

Open

oliviertassinari deleted the autocomplete-remove-activedescendant branch February 8, 2020 20:41

snyk-bot mentioned this pull request Feb 15, 2020

[Snyk] Upgrade @material-ui/core from 4.3.1 to 4.9.0 aubreyyan/1f5374286c#17

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Autocomplete] Remove aria-activedescendant #18281

[Autocomplete] Remove aria-activedescendant #18281

Uh oh!

oliviertassinari commented Nov 9, 2019

Uh oh!

mui-pr-bot commented Nov 9, 2019 •

edited

Loading

Uh oh!

oliviertassinari Nov 10, 2019

Uh oh!

oliviertassinari Nov 10, 2019

Uh oh!

oliviertassinari Nov 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

[Autocomplete] Remove aria-activedescendant #18281

[Autocomplete] Remove aria-activedescendant #18281

Uh oh!

Conversation

oliviertassinari commented Nov 9, 2019

Uh oh!

mui-pr-bot commented Nov 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oliviertassinari Nov 10, 2019

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Nov 10, 2019

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Nov 10, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mui-pr-bot commented Nov 9, 2019 •

edited

Loading