Skip to content

Conversation

@FabianSellmann
Copy link
Contributor

@FabianSellmann FabianSellmann commented Nov 7, 2019

Adds tests that fails without the fix.
Removes deepmerge option to use default (clone: true).

FIxes #18245

@FabianSellmann FabianSellmann changed the title [core] Fix cloning in createPallette & createTypography [core] Fix merging in createPallette Nov 7, 2019
@FabianSellmann FabianSellmann changed the title [core] Fix merging in createPallette [core] Fix merging in createPalette Nov 7, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 7, 2019

Details of bundle changes.

Comparing: b29c294...b19a94c

bundle Size Change Size Gzip Change Gzip
Autocomplete ▼ -11 B (-0.01% ) 125 kB ▲ +6 B (+0.02% ) 39.6 kB
docs.main ▼ -11 B (-0.00% ) 603 kB ▲ +6 B (0.00% ) 192 kB
Snackbar ▼ -11 B (-0.01% ) 75.5 kB ▲ +5 B (+0.02% ) 23.5 kB
GridListTileBar ▼ -11 B (-0.02% ) 61.6 kB ▲ +4 B (+0.02% ) 19.3 kB
ListItemText ▼ -11 B (-0.02% ) 63.4 kB ▲ +4 B (+0.02% ) 19.9 kB
SpeedDial ▼ -11 B (-0.01% ) 84.3 kB ▲ +4 B (+0.02% ) 26.6 kB
SpeedDialAction ▼ -11 B (-0.01% ) 114 kB ▲ +4 B (+0.01% ) 36 kB
Toolbar ▼ -11 B (-0.02% ) 60.8 kB ▲ +4 B (+0.02% ) 19 kB
Avatar ▼ -11 B (-0.02% ) 61.2 kB ▲ +3 B (+0.02% ) 19.3 kB
BottomNavigationAction ▼ -11 B (-0.01% ) 73.8 kB ▲ +3 B (+0.01% ) 23.3 kB
Button ▼ -11 B (-0.01% ) 77.7 kB ▲ +3 B (+0.01% ) 24.1 kB
ButtonGroup ▼ -11 B (-0.02% ) 62.7 kB ▲ +3 B (+0.02% ) 19.5 kB
Card ▼ -11 B (-0.02% ) 61.2 kB ▲ +3 B (+0.02% ) 19.1 kB
CardActionArea ▼ -11 B (-0.01% ) 73.3 kB ▲ +3 B (+0.01% ) 23.1 kB
CardActions ▼ -11 B (-0.02% ) 60.5 kB ▲ +3 B (+0.02% ) 18.9 kB
CardContent ▼ -11 B (-0.02% ) 60.4 kB ▲ +3 B (+0.02% ) 18.9 kB
CardMedia ▼ -11 B (-0.02% ) 60.8 kB ▲ +3 B (+0.02% ) 19.1 kB
Container ▼ -11 B (-0.02% ) 61.6 kB ▲ +3 B (+0.02% ) 19.2 kB
CssBaseline ▼ -11 B (-0.02% ) 56 kB ▲ +3 B (+0.02% ) 17.5 kB
Dialog ▼ -11 B (-0.01% ) 80.9 kB ▲ +3 B (+0.01% ) 25.1 kB
DialogActions ▼ -11 B (-0.02% ) 60.5 kB ▲ +3 B (+0.02% ) 18.9 kB
DialogContent ▼ -11 B (-0.02% ) 60.6 kB ▲ +3 B (+0.02% ) 19 kB
Divider ▼ -11 B (-0.02% ) 61 kB ▲ +3 B (+0.02% ) 19.1 kB
FormGroup ▼ -11 B (-0.02% ) 60.4 kB ▲ +3 B (+0.02% ) 18.9 kB
FormHelperText ▼ -11 B (-0.02% ) 61.7 kB ▲ +3 B (+0.02% ) 19.3 kB
Grid ▼ -11 B (-0.02% ) 63.5 kB ▲ +3 B (+0.02% ) 19.9 kB
GridList ▼ -11 B (-0.02% ) 60.9 kB ▲ +3 B (+0.02% ) 19.1 kB
List ▼ -11 B (-0.02% ) 60.8 kB ▲ +3 B (+0.02% ) 18.9 kB
ListItemAvatar ▼ -11 B (-0.02% ) 60.5 kB ▲ +3 B (+0.02% ) 18.9 kB
RadioGroup ▼ -11 B (-0.02% ) 61.7 kB ▲ +3 B (+0.02% ) 19.3 kB
Skeleton ▼ -11 B (-0.02% ) 60.9 kB ▲ +3 B (+0.02% ) 19.1 kB
SnackbarContent ▼ -11 B (-0.02% ) 64.1 kB ▲ +3 B (+0.01% ) 20.1 kB
SpeedDialIcon ▼ -11 B (-0.02% ) 63 kB ▲ +3 B (+0.02% ) 19.8 kB
StepButton ▼ -11 B (-0.01% ) 80.6 kB ▲ +3 B (+0.01% ) 25.3 kB
StepConnector ▼ -11 B (-0.02% ) 61.1 kB ▲ +3 B (+0.02% ) 19.2 kB
StepContent ▼ -11 B (-0.02% ) 67.4 kB ▲ +3 B (+0.01% ) 21 kB
TableFooter ▼ -11 B (-0.02% ) 60.5 kB ▲ +3 B (+0.02% ) 18.9 kB
TableHead ▼ -11 B (-0.02% ) 60.5 kB ▲ +3 B (+0.02% ) 18.9 kB
ToggleButton ▼ -11 B (-0.01% ) 74.4 kB ▲ +3 B (+0.01% ) 23.5 kB
ToggleButtonGroup ▼ -11 B (-0.02% ) 61.6 kB ▲ +3 B (+0.02% ) 19.4 kB
TreeItem ▼ -11 B (-0.02% ) 71.9 kB ▲ +3 B (+0.01% ) 22.6 kB
TreeView ▼ -11 B (-0.02% ) 64.8 kB ▲ +3 B (+0.01% ) 20.3 kB
Backdrop ▼ -11 B (-0.02% ) 66.2 kB ▲ +2 B (+0.01% ) 20.4 kB
Badge ▼ -11 B (-0.02% ) 63.8 kB ▲ +2 B (+0.01% ) 19.7 kB
BottomNavigation ▼ -11 B (-0.02% ) 60.8 kB ▲ +2 B (+0.01% ) 19 kB
ButtonBase ▼ -11 B (-0.02% ) 72.2 kB ▲ +2 B (+0.01% ) 22.6 kB
Checkbox ▼ -11 B (-0.01% ) 80.1 kB ▲ +2 B (+0.01% ) 25.1 kB
CircularProgress ▼ -11 B (-0.02% ) 62.5 kB ▲ +2 B (+0.01% ) 19.7 kB
Collapse ▼ -11 B (-0.02% ) 66.3 kB ▲ +2 B (+0.01% ) 20.5 kB
DialogContentText ▼ -11 B (-0.02% ) 62.5 kB ▲ +2 B (+0.01% ) 19.6 kB
DialogTitle ▼ -11 B (-0.02% ) 62.7 kB ▲ +2 B (+0.01% ) 19.7 kB
Drawer ▼ -11 B (-0.01% ) 82.7 kB ▲ +2 B (+0.01% ) 25.6 kB
ExpansionPanel ▼ -11 B (-0.02% ) 69.6 kB ▲ +2 B (+0.01% ) 21.7 kB
ExpansionPanelActions ▼ -11 B (-0.02% ) 60.5 kB ▲ +2 B (+0.01% ) 18.9 kB
ExpansionPanelDetails ▼ -11 B (-0.02% ) 60.4 kB ▲ +2 B (+0.01% ) 18.9 kB
Fab ▼ -11 B (-0.01% ) 75.1 kB ▲ +2 B (+0.01% ) 23.3 kB
Fade ▼ -11 B (-0.05% ) 22 kB ▼ -2 B (-0.03% ) 7.6 kB
FormControl ▼ -11 B (-0.02% ) 62.8 kB ▲ +2 B (+0.01% ) 19.5 kB
FormLabel ▼ -11 B (-0.02% ) 61.9 kB ▲ +2 B (+0.01% ) 19.1 kB
GridListTile ▼ -11 B (-0.02% ) 62.2 kB ▲ +2 B (+0.01% ) 19.5 kB
Icon ▼ -11 B (-0.02% ) 61.2 kB ▲ +2 B (+0.01% ) 19.2 kB
InputAdornment ▼ -11 B (-0.02% ) 63.5 kB ▲ +2 B (+0.01% ) 20 kB
InputBase ▼ -11 B (-0.02% ) 69 kB ▲ +2 B (+0.01% ) 21.6 kB
Link ▼ -11 B (-0.02% ) 65 kB ▲ +2 B (+0.01% ) 20.6 kB
ListItem ▼ -11 B (-0.01% ) 75.4 kB ▲ +2 B (+0.01% ) 23.5 kB
ListItemIcon ▼ -11 B (-0.02% ) 60.6 kB ▲ +2 B (+0.01% ) 19 kB
ListItemSecondaryAction ▼ -11 B (-0.02% ) 60.4 kB ▲ +2 B (+0.01% ) 18.9 kB
ListSubheader ▼ -11 B (-0.02% ) 61.2 kB ▲ +2 B (+0.01% ) 19.2 kB
MobileStepper ▼ -11 B (-0.02% ) 66.2 kB ▲ +2 B (+0.01% ) 20.6 kB
Popover ▼ -11 B (-0.01% ) 81 kB ▲ +2 B (+0.01% ) 25 kB
Rating ▼ -11 B (-0.02% ) 68.3 kB ▲ +2 B (+0.01% ) 21.8 kB
Select ▼ -11 B (-0.01% ) 112 kB ▲ +2 B (+0.01% ) 33.4 kB
Step ▼ -11 B (-0.02% ) 61 kB ▲ +2 B (+0.01% ) 19.1 kB
StepIcon ▼ -11 B (-0.02% ) 63.1 kB ▲ +2 B (+0.01% ) 19.6 kB
StepLabel ▼ -11 B (-0.02% ) 67 kB ▲ +2 B (+0.01% ) 21 kB
SwipeableDrawer ▼ -11 B (-0.01% ) 90 kB ▲ +2 B (+0.01% ) 27.9 kB
Tab ▼ -11 B (-0.01% ) 74.6 kB ▲ +2 B (+0.01% ) 23.6 kB
Table ▼ -11 B (-0.02% ) 61 kB ▲ +2 B (+0.01% ) 19.1 kB
TableBody ▼ -11 B (-0.02% ) 60.5 kB ▲ +2 B (+0.01% ) 18.9 kB
TableCell ▼ -11 B (-0.02% ) 62.5 kB ▲ +2 B (+0.01% ) 19.6 kB
TableRow ▼ -11 B (-0.02% ) 61 kB ▲ +2 B (+0.01% ) 19.1 kB
TableSortLabel ▼ -11 B (-0.01% ) 75.6 kB ▲ +2 B (+0.01% ) 23.9 kB
Tooltip ▼ -11 B (-0.01% ) 97.6 kB ▲ +2 B (+0.01% ) 30.9 kB
@material-ui/core ▼ -11 B (-0.00% ) 349 kB ▲ +1 B (0.00% ) 95.6 kB
@material-ui/lab ▼ -11 B (-0.01% ) 169 kB ▲ +1 B (0.00% ) 50.9 kB
Box ▼ -11 B (-0.02% ) 69.2 kB ▲ +1 B (0.00% ) 20.9 kB
Chip ▼ -11 B (-0.01% ) 81 kB ▲ +1 B (0.00% ) 24.7 kB
ExpansionPanelSummary ▼ -11 B (-0.01% ) 76.4 kB ▲ +1 B (0.00% ) 24.1 kB
FormControlLabel ▼ -11 B (-0.02% ) 63.9 kB ▲ +1 B (0.00% ) 20.1 kB
Grow ▼ -11 B (-0.05% ) 22.6 kB ▼ -1 B (-0.01% ) 7.72 kB
Hidden ▼ -11 B (-0.02% ) 64.5 kB ▲ +1 B (0.00% ) 20.2 kB
IconButton ▼ -11 B (-0.01% ) 74.4 kB ▲ +1 B (0.00% ) 23.2 kB
InputLabel ▼ -11 B (-0.02% ) 63.7 kB ▲ +1 B (+0.01% ) 19.8 kB
Menu ▼ -11 B (-0.01% ) 86.6 kB ▼ -1 B (-0.00% ) 27.2 kB
MenuItem ▼ -11 B (-0.01% ) 76.4 kB ▲ +1 B (0.00% ) 23.8 kB
MenuList ▼ -11 B (-0.02% ) 64.4 kB ▲ +1 B (0.00% ) 20.1 kB
NativeSelect ▼ -11 B (-0.01% ) 75.2 kB ▲ +1 B (0.00% ) 23.7 kB
Paper ▼ -11 B (-0.02% ) 60.7 kB ▲ +1 B (+0.01% ) 18.9 kB
Radio ▼ -11 B (-0.01% ) 80.9 kB ▼ -1 B (-0.00% ) 25.4 kB
Slide ▼ -11 B (-0.05% ) 24.1 kB ▼ -1 B (-0.01% ) 8.21 kB
Slider ▼ -11 B (-0.01% ) 73.9 kB ▲ +1 B (0.00% ) 23.3 kB
Stepper ▼ -11 B (-0.02% ) 63.2 kB ▲ +1 B (+0.01% ) 19.9 kB
styles/createMuiTheme ▼ -11 B (-0.07% ) 15.2 kB ▼ -1 B (-0.02% ) 5.36 kB
SvgIcon ▼ -11 B (-0.02% ) 61.5 kB ▲ +1 B (+0.01% ) 19.1 kB
Switch ▼ -11 B (-0.01% ) 79.4 kB ▲ +1 B (0.00% ) 24.7 kB
Tabs ▼ -11 B (-0.01% ) 83.7 kB ▲ +1 B (0.00% ) 26.6 kB
TextField ▼ -11 B (-0.01% ) 121 kB ▲ +1 B (0.00% ) 35.4 kB
Zoom ▼ -11 B (-0.05% ) 22.1 kB ▲ +1 B (+0.01% ) 7.6 kB
@material-ui/core[umd] ▼ -11 B (-0.00% ) 309 kB -- 88.9 kB
AppBar ▼ -11 B (-0.02% ) 62.2 kB -- 19.5 kB
Breadcrumbs ▼ -11 B (-0.02% ) 66.4 kB -- 20.8 kB
CardHeader ▼ -11 B (-0.02% ) 63.5 kB -- 20 kB
FilledInput ▼ -11 B (-0.02% ) 72 kB -- 22.3 kB
Input ▼ -11 B (-0.02% ) 70.9 kB -- 22.1 kB
LinearProgress ▼ -11 B (-0.02% ) 63.8 kB -- 19.9 kB
OutlinedInput ▼ -11 B (-0.02% ) 72.5 kB -- 22.5 kB
TablePagination ▼ -11 B (-0.01% ) 139 kB -- 40.5 kB
Typography ▼ -11 B (-0.02% ) 62.1 kB -- 19.3 kB
@material-ui/styles -- 50.8 kB -- 15.4 kB
@material-ui/system -- 14.8 kB -- 4.06 kB
ClickAwayListener -- 3.85 kB -- 1.55 kB
colorManipulator -- 3.83 kB -- 1.52 kB
docs.landing -- 55.6 kB -- 14.6 kB
Modal -- 14.2 kB -- 4.96 kB
NoSsr -- 2.19 kB -- 1.04 kB
Popper -- 28.5 kB -- 10.2 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.43 kB -- 1.67 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
useAutocomplete -- 11.7 kB -- 4.32 kB
useMediaQuery -- 2.49 kB -- 1.05 kB

Generated by 🚫 dangerJS against b19a94c

@FabianSellmann FabianSellmann changed the title [core] Fix merging in createPalette [core] Fix merging defaults with given options in createPalette Nov 7, 2019
@oliviertassinari oliviertassinari changed the title [core] Fix merging defaults with given options in createPalette [core] Fix createMuiTheme side-effect Nov 7, 2019
@oliviertassinari oliviertassinari added the type: bug It doesn't behave as expected. label Nov 7, 2019
@oliviertassinari oliviertassinari merged commit 4abf761 into mui:master Nov 7, 2019
@oliviertassinari
Copy link
Member

Thank you for the report, as well as the fix, great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

createMuiTheme modifies previously created theme

3 participants