[TextField] Add demo for color prop #18220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 7f09ea4...a6e725e |
oliviertassinari
requested changes
Nov 5, 2019
oliviertassinari
added
docs
Contributor
Author
|
Where should it be put on the page? Also, should the demo show both styles or only the non-default |
Member
|
@Studio384 I think that showing the secondary color would be enough. What do you think of having it right before "Customized inputs"? |
joshwooding
reviewed
Nov 5, 2019
oliviertassinari
approved these changes
Nov 6, 2019
Member
|
@Studio384 Well done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It struck me as odd that there was no demo for this. Given that all color variation demos are done in the first demo, I've added them there.