Skip to content

[core] Remove typings for /es build #14422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2019
Merged

[core] Remove typings for /es build #14422

merged 1 commit into from
Feb 5, 2019

Conversation

@eps1lon
Copy link
Member

@eps1lon eps1lon commented Feb 5, 2019 •
edited
Loading

BREAKING (ts-only)

- import Button from '@material-ui/core/es/Button'
+ // aliased @material-ui/core to @material-ui/core/es in tsconfig and build pipeline
+ import Button from '@material-ui/core/Button'

Extensive explanation in #14392

Closes #14392

@eps1lon eps1lon added breaking change Introduces changes that are not backward compatible. typescript labels Feb 5, 2019
@eps1lon eps1lon added this to the v4 milestone Feb 5, 2019
oliviertassinari
oliviertassinari approved these changes Feb 5, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 https://packagephobia.now.sh/result?p=%40material-ui%2Fcore is going to like that 👍

@oliviertassinari oliviertassinari merged commit 34f3674 into mui:next Feb 5, 2019
@eps1lon eps1lon deleted the build/remove-es-typings branch February 5, 2019 21:56
@eps1lon eps1lon mentioned this pull request Feb 8, 2019
Closed
56 tasks
@flaviendelangle flaviendelangle mentioned this pull request Sep 3, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. typescript

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@eps1lon @oliviertassinari