[docs] Improve typescript issue assistance #12560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://codesandbox.io/s/react-ts uses the same workaround. Related codesandbox issue: codesandbox/codesandbox-client#514
Typescript pulls types from parent directories (which means types used in core). This currently leads to a ts error along the line of "cannot simultaneously extends types X and Y". See also microsoft/TypeScript#11363
oliviertassinari
changed the title
oliviertassinari
added
docs
oliviertassinari
approved these changes
Aug 17, 2018
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the number of issues with typescript is quite significant I decided to ask for useful informations in the issue template.
Especially now with the release of typescript 3 I expect more issues that are hard to replicate without knowing typescript version and the used tsconfig.
There was already a useful codesandbox template which isn't working at the moment but is fixed with this PR.
master: https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/create-react-app-with-typescript
PR: https://codesandbox.io/s/github/eps1lon/material-ui/tree/typescript-issues/examples/create-react-app-with-typescript
Since all of these changes are closely related to one another I decided to bundle these. Just let me know if I should file these separately or squash etc.