[core] Should run the tests when needed #12510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
test-fix-ci-packages
branch
5 times, most recently
from
b9744cc to
34b5faa
Compare
oliviertassinari
force-pushed
the
test-fix-ci-packages
branch
from
34b5faa to
82a630a
Compare
Member
Author
|
@mbrookes The lab tests are broken. I haven't looked into it. Hopefully, now, we will prevent regressions. |
Member
|
One was broken (#11889 (comment)), but it's likely that subsequent PRs have broken more tests. I'll take a look tomorrow. |
Member
|
@mbrookes I'm currently fixing errors in |
Member
|
I took a look, it's the same one, but I can't see an obvious cause. |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run the packages/x tests when changed.