[Textarea] Add back defensive branch logic #12406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes `disableLifecycleMethods` option from shallow render test to demonstrate the test failures that occur when that option is not set.
Fixes shallow rendering test failures by adding the defensive branch logic back, along with a comment.
oliviertassinari
added
type: new feature
Member
|
It makes me sad to have to merge changes like this. But anyway, let's work around the "broken" shallow method behavior. |
Member
|
@kanzelm3 It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot! |
Contributor
Author
|
@oliviertassinari thanks! |
|
Could this defensive guard fix a similar Jest error I see in Tabs? TypeError: Cannot read property 'scrollWidth' of null |
Member
|
@cobbs-totem Sure, if you want to work on it, I have no objection with that. |
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes shallow rendering test failures by adding back the defensive branch logic that was removed in #12238, along with a comment this time.
Closes #12247